Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All user saved albums #1945

Merged
merged 4 commits into from
Oct 30, 2023
Merged

All user saved albums #1945

merged 4 commits into from
Oct 30, 2023

Conversation

edy252
Copy link
Contributor

@edy252 edy252 commented Oct 27, 2023

Title

Adds ability to download and sync tracks from the current user's saved albums on Spotify.

Description

I used the existing current_user_saved_albums function to retrieve the user's saved albums, and added a new CLI argument "get_user_saved_albums". This works with the download and sync operations.

Related Issue

#1940

Motivation and Context

It allows the user to pull their saved albums and download / sync them.

How Has This Been Tested?

I setup the environment using the commands in the contributing page.
I tested these commands:
spotdl all-user-saved-albums --user-auth
spotdl sync all-user-saved-albums --user-auth --save-file sample.spotdl
I checked for these things:

  • Download all songs from saved albums on Spotify
  • Sync all songs from saved albums on Spotify, skipping items already sync'ed with a spotdl file
  • Sync using this command. Then save a new album on Spotify. Run this command. Make sure that already existing songs are skipped, and songs from the newly saved album are downloaded.
  • But if after running the sync command, you un-save an album from your Spotify, then the songs belonging to that album are not deleted. Not sure how to proceed with this.
  • Run pytest to see that 121/129 existing tests passed (for this branch and for my master branch)

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes Not sure how to add a test for this
  • All new and existing tests passed Both my branch and my master fail 8 tests

@xnetcat xnetcat changed the base branch from master to dev October 30, 2023 08:23
@xnetcat xnetcat merged commit ab5ef17 into spotDL:dev Oct 30, 2023
0 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants