Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proxy server download song. (#1911) #1912

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

Tunglies
Copy link
Contributor

@Tunglies Tunglies commented Sep 29, 2023

Title

Http request proxy server support.

Description

Add proxy server support for requesting bandcamp, piped, sliderkz, genius, musixmatch, metadata.

Related Issue

#1911

Motivation and Context

Downloading music from region likes in China needs proxy server.

How Has This Been Tested?

Build from source and run as expected.

Screenshots (if appropriate)

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@xnetcat xnetcat changed the base branch from master to dev October 6, 2023 09:44
@xnetcat xnetcat merged commit b696195 into spotDL:dev Oct 6, 2023
@xnetcat xnetcat mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants