Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to add spotipy #1693

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Update Dockerfile to add spotipy #1693

merged 2 commits into from
Dec 28, 2022

Conversation

frgaudet
Copy link
Contributor

Title

Adding missing spotipy dependency in Dockerfile

Description

Related Issue

Motivation and Context

Docker build fail with this error message

Using python3.10 (3.10.8)
Creating virtualenv spotdl-1HQUp4N1-py3.10 in /root/.cache/pypoetry/virtualenvs
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/music/spotdl/__init__.py", line 13, in <module>
    from spotdl.utils.spotify import SpotifyClient
  File "/music/spotdl/utils/spotify.py", line 14, in <module>
    from spotipy import Spotify
ModuleNotFoundError: No module named 'spotipy'

How Has This Been Tested?

Tested on MacOSX 12.6.1

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • [] My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Adding missing spotipy dependency
@Silverarmor Silverarmor changed the base branch from master to dev December 15, 2022 08:53
@xnetcat
Copy link
Member

xnetcat commented Dec 15, 2022

This shouldn't be happening, spotipy gets installed with poetry
https://github.com/spotDL/spotify-downloader/blob/master/Dockerfile#L24

What was the command that you ran / Dockerfile?

@xnetcat xnetcat merged commit 62e80ce into spotDL:dev Dec 28, 2022
@xnetcat xnetcat mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants