Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: errors from getSporeById are mixed #131

Merged
merged 2 commits into from
Aug 10, 2024
Merged

bug: errors from getSporeById are mixed #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fced8e
bug: errors from getSporeById are mixed
ashuralyk Aug 1, 2024
cfaef44
chore: add changeset log
ashuralyk Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-elephants-behave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@spore-sdk/core': patch
---

fix vulnerability in getSporeById interface
14 changes: 4 additions & 10 deletions packages/core/src/api/joints/spore/getSpore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,19 +63,13 @@ export async function getSporeById(id: HexString, config?: SporeConfig): Promise
// Get SporeType script
const sporeScript = getSporeScriptCategory(config, 'Spore');
const scripts = (sporeScript.versions ?? []).map((r) => r.script);
const indexer = new Indexer(config.ckbIndexerUrl, config.ckbNodeUrl);

// Search target spore from the latest version to the oldest
for (const script of scripts) {
try {
return await getSporeByType(
{
...script,
args: id,
},
config,
);
} catch {
// Not found in the script, don't have to do anything
const cell = await getCellByType({ type: { ...script, args: id }, indexer });
if (cell !== void 0) {
return cell;
}
}

Expand Down
Loading