-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ancestors of packages to packages in setup.py #105
Merged
dahlia
merged 8 commits into
nirum-lang:master
from
AiOO:bugfix/add-ancestors-of-packages
Mar 8, 2017
Merged
Add ancestors of packages to packages in setup.py #105
dahlia
merged 8 commits into
nirum-lang:master
from
AiOO:bugfix/add-ancestors-of-packages
Mar 8, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiOO
force-pushed
the
bugfix/add-ancestors-of-packages
branch
from
March 7, 2017 14:54
421c37a
to
5317470
Compare
dahlia
approved these changes
Mar 7, 2017
kanghyojun
approved these changes
Mar 7, 2017
dahlia
requested changes
Mar 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AiOO Seems tests of generated Python code are broken. Try run tox
on your local machine.
dahlia
approved these changes
Mar 8, 2017
헐 머지 제가 하려고 했는데 |
dahlia
added
cat:packaging
Category: Nirum schema packaging (not compiler packaging)
cmp:compiler
Component: Compiler backend (e.g., annotation processors, code generators)
target:python
labels
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:packaging
Category: Nirum schema packaging (not compiler packaging)
cmp:compiler
Component: Compiler backend (e.g., annotation processors, code generators)
target:python
typ:bug
Type: Bug/defect
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #92