Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ancestors of packages to packages in setup.py #105

Merged
merged 8 commits into from
Mar 8, 2017

Conversation

AiOO
Copy link
Collaborator

@AiOO AiOO commented Mar 7, 2017

This PR closes #92

@AiOO AiOO requested review from dahlia and Kroisse March 7, 2017 14:50
@AiOO AiOO force-pushed the bugfix/add-ancestors-of-packages branch from 421c37a to 5317470 Compare March 7, 2017 14:54
@AiOO AiOO requested a review from kanghyojun March 7, 2017 16:51
Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AiOO Seems tests of generated Python code are broken. Try run tox on your local machine.

@dahlia dahlia added the typ:bug Type: Bug/defect label Mar 7, 2017
@dahlia dahlia merged commit 03c012d into nirum-lang:master Mar 8, 2017
@AiOO
Copy link
Collaborator Author

AiOO commented Mar 8, 2017

헐 머지 제가 하려고 했는데

@dahlia dahlia added cat:packaging Category: Nirum schema packaging (not compiler packaging) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python labels Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:packaging Category: Nirum schema packaging (not compiler packaging) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python typ:bug Type: Bug/defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants