-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nirum.Constructs.ModulePath.spreadModulePath. #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiOO
force-pushed
the
add-root-packagename
branch
3 times, most recently
from
February 28, 2017 17:55
d6a4238
to
ee78246
Compare
AiOO
changed the title
[WIP] Add root package name of nirum
Add Nirum.Constructs.ModulePath.spreadModulePath.
Feb 28, 2017
AiOO
force-pushed
the
add-root-packagename
branch
from
February 28, 2017 18:13
ee78246
to
2e6e1b2
Compare
dahlia
requested changes
Feb 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@admire93 빌드가 깨졌는데 이 PR에서 바뀐 부분 때문이 아니라 파이썬 3.5.3에서
|
AiOO
force-pushed
the
add-root-packagename
branch
from
March 7, 2017 11:10
2e6e1b2
to
45eb488
Compare
일단 리베이스해서 올려뒀습니다. |
AiOO
force-pushed
the
add-root-packagename
branch
from
March 7, 2017 12:26
54e8932
to
f8072b8
Compare
이름도 바꿨습니다. |
dahlia
approved these changes
Mar 7, 2017
Approved! |
AiOO
approved these changes
Mar 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
자추 💯
Fixed in #105 |
dahlia
added
cmp:compiler
Component: Compiler backend (e.g., annotation processors, code generators)
cmp:frontend
Component: Compiler frontend (e.g., CLI, parser, AST)
labels
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmp:compiler
Component: Compiler backend (e.g., annotation processors, code generators)
cmp:frontend
Component: Compiler frontend (e.g., CLI, parser, AST)
typ:bug
Type: Bug/defect
typ:enhance
Type: Enhancement/new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModulePath를 분리하는 seperateModulePath 함수를 추가합니다. 예를 들어 a.b.c를 가리키는 ModulePath가 있다면, ['a', 'a.b', 'a.b.c'] 형태로 리턴합니다. 자세한 내용은 코드를 참조하세요.
With @AiOO