Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nirum.Constructs.ModulePath.spreadModulePath. #94

Closed
wants to merge 2 commits into from

Conversation

kanghyojun
Copy link
Member

@kanghyojun kanghyojun commented Feb 19, 2017

ModulePath를 분리하는 seperateModulePath 함수를 추가합니다. 예를 들어 a.b.c를 가리키는 ModulePath가 있다면, ['a', 'a.b', 'a.b.c'] 형태로 리턴합니다. 자세한 내용은 코드를 참조하세요.

With @AiOO

@AiOO AiOO force-pushed the add-root-packagename branch 3 times, most recently from d6a4238 to ee78246 Compare February 28, 2017 17:55
@AiOO AiOO changed the title [WIP] Add root package name of nirum Add Nirum.Constructs.ModulePath.spreadModulePath. Feb 28, 2017
@AiOO AiOO force-pushed the add-root-packagename branch from ee78246 to 2e6e1b2 Compare February 28, 2017 18:13
@AiOO AiOO self-assigned this Feb 28, 2017
Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AiOO @admire93 파이썬 표준 라이브러리에 있는 pathlib 모듈에도 비슷한 용도의 속성이 있는데, 이름이 .parents입니다. 우리도 비슷한 느낌의 이름을 쓰는 게 어떨까요?

@dahlia dahlia added typ:bug Type: Bug/defect typ:enhance Type: Enhancement/new feature labels Feb 28, 2017
@dahlia
Copy link
Member

dahlia commented Mar 1, 2017

@admire93 빌드가 깨졌는데 이 PR에서 바뀐 부분 때문이 아니라 파이썬 3.5.3에서 typing.UnionMeta 사라진 것 때문이네요.

AttributeError: 'module' object has no attribute 'UnionMeta'

@dahlia
Copy link
Member

dahlia commented Mar 1, 2017

@admire93 빌드가 깨졌는데 이 PR에서 바뀐 부분 때문이 아니라 파이썬 3.5.3에서 typing.UnionMeta 사라진 것 때문이네요.

다시 보니까 nirum-python 최신 버전에서는 이미 고쳐졌는데 컴파일러 쪽 tox.ini에서 예전 버전을 바라보게 되어 있어서 그랬네요. 방금 #98 PR 올렸는데, 이거 병합한 뒤에 리베이스하면 빌드는 해결될 것 같습니다. @admire93 @AiOO 리뷰 부탁드립니다.

@dahlia
Copy link
Member

dahlia commented Mar 2, 2017

@AiOO 마스터에 #98 들어갔으니 리베이스하면 빌드 통과할 겁니다.

@AiOO AiOO force-pushed the add-root-packagename branch from 2e6e1b2 to 45eb488 Compare March 7, 2017 11:10
@AiOO
Copy link
Collaborator

AiOO commented Mar 7, 2017

일단 리베이스해서 올려뒀습니다.

@AiOO AiOO force-pushed the add-root-packagename branch from 54e8932 to f8072b8 Compare March 7, 2017 12:26
@AiOO
Copy link
Collaborator

AiOO commented Mar 7, 2017

이름도 바꿨습니다.

@kanghyojun
Copy link
Member Author

Approved!

@AiOO AiOO self-requested a review March 7, 2017 12:52
Copy link
Collaborator

@AiOO AiOO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자추 💯

@AiOO
Copy link
Collaborator

AiOO commented Mar 7, 2017

Fixed in #105

@AiOO AiOO closed this Mar 7, 2017
@dahlia dahlia added cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) labels Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) typ:bug Type: Bug/defect typ:enhance Type: Enhancement/new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants