Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /reissue api 예외처리 #348

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix: /reissue api 예외처리 #348

merged 1 commit into from
Jul 4, 2024

Conversation

oxdjww
Copy link
Member

@oxdjww oxdjww commented Jul 3, 2024

☝️Issue Number

🔎 Key Changes

  • GlobalExceptionHandler에서 SecurityCustomException 예외처리 로직 추가

💌 To Reviewers

  • token 관련 에러는 JwtAuthenticationFilter에서 발생하기에, 이는 이전 필터인 JwtExceptionFilter 혹은 JwtAuthenticationEntryPoint에서 처리해주도록 구현되어 있었습니다
  • 하지만 /reissue api에서 토큰 관련 에러가 생기면 이는 필터를 이미 통과한 뒤이기에 servlet에서 에러가 catch되기 때문에 아래와 같은 예외가 뜨게 되어 이를 토큰에러(손상, 만료 등)로 처리할 수 있도록 수정하였습니다.
    image

@oxdjww oxdjww added fix Something isn't working refactor Refactoring code labels Jul 3, 2024
@oxdjww oxdjww self-assigned this Jul 3, 2024
@oxdjww oxdjww linked an issue Jul 3, 2024 that may be closed by this pull request
1 task
Copy link
Member

@xxoznge xxoznge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@oxdjww oxdjww merged commit 9b63a38 into develop Jul 4, 2024
1 check passed
@oxdjww oxdjww deleted the fix/#347 branch July 4, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something isn't working refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: reissue api 반환 양식 통일
2 participants