Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 조직 링크 & 태그 도메인 delete 이전에 존재 여부 파악 로직 추가 #260

Merged
merged 3 commits into from
Apr 15, 2024
Merged

fix: 조직 링크 & 태그 도메인 delete 이전에 존재 여부 파악 로직 추가 #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
217c568
fix: Tag delete시 존재하지 않은 데이터를 지우려고 시도할 시 NOT_FOUND 예외 처리
yj-lee00 Mar 16, 2024
d8ded45
fix: OrganizationLink delete시 존재하지 않은 데이터를 지우려고 시도할 시 NOT_FOUND 예외 처리
yj-lee00 Mar 16, 2024
11c2872
Merge branch 'develop' into fix/#259
kimday0326 Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ain/java/com/sponus/sponusbe/domain/organizationLink/service/OrganizationLinkService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ public void updateOrganizationLink(Long organizationLinkId, OrganizationLinkUpda
}

public void deleteOrganizationLink(Long organizationLinkId) {
organizationLinkRepository.deleteById(organizationLinkId);
if (organizationLinkRepository.existsById(organizationLinkId)) {
organizationLinkRepository.deleteById(organizationLinkId);
} else {
throw new OrganizationLinkException(ORGANIZATION_LINK_NOT_FOUND);
}
}
}
8 changes: 7 additions & 1 deletion api/src/main/java/com/sponus/sponusbe/domain/tag/service/TagService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

import lombok.RequiredArgsConstructor;

import java.util.Optional;

@Transactional
@RequiredArgsConstructor
@Service
Expand All @@ -37,7 +39,11 @@ public TagCreateResponse createTag(Long organizationId, TagCreateRequest request
}

public void deleteTag(Long tagId) {
tagRepository.deleteById(tagId);
if (tagRepository.existsById(tagId)) {
tagRepository.deleteById(tagId);
} else {
throw new TagException(TAG_NOT_FOUND);
}
}

public void updateTag(Long tagId, TagUpdateRequest request) {
Expand Down
Loading