-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utf-8 issue breaks rake assets:precompile #7
Conversation
I've recently changed the way those assets are copied in the precompile phase so that they shouldn't run through Sprockets (and blow up with utf encoding issues). Do you possibly have |
in production.rb I've got: |
I'm having trouble reproducing this. Are you able to upload a test app that exhibits the problem? |
I just spent about an hour trying to reproduce this and can't. The app started being built agains 3.1.0rc1, I must have had an older dependency in there somewhere. Sorry for the false alarm. |
Not a problem. I'm going to release the 3.4.5 gem today so please let me know if you have any issues with that. |
I'm also seeing this issue. 3.4.4 is fine, but 3.4.5 breaks with: rake aborted! |
@digitalphotogallery I'm not able to reproduce this. What is the value of Can you upload a minimal app that has the issue? |
config.serve_static_assets = false I'm going to try and create a clean application now to see if I can reproduce the problem. |
I found the cause. The issue was related to my application. I run scripts to deploy and one of them was running 'bundle exec rake assets:precompile RAILS_ENV=development' on the test server which was causing the rake to fail. In production 'bundle exec rake assets:precompile RAILS_ENV=production' works fine. Thank you for such a fast response. |
This commit (I hope) fixes a utf-8 encoding problem in the tinymce source that caused rake assets:precompile to blow up on me using ruby 1.9.2. I didn't do any regression test for 1.8.7.
(This is my first time putting in a pull request, so please let me know if there is something I could do better)