Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf-8 issue breaks rake assets:precompile #7

Closed
wants to merge 1 commit into from

Conversation

sfaxon
Copy link

@sfaxon sfaxon commented Sep 6, 2011

This commit (I hope) fixes a utf-8 encoding problem in the tinymce source that caused rake assets:precompile to blow up on me using ruby 1.9.2. I didn't do any regression test for 1.8.7.

(This is my first time putting in a pull request, so please let me know if there is something I could do better)

@spohlenz
Copy link
Owner

spohlenz commented Sep 7, 2011

I've recently changed the way those assets are copied in the precompile phase so that they shouldn't run through Sprockets (and blow up with utf encoding issues).

Do you possibly have config.serve_static_assets enabled in production mode?

@sfaxon
Copy link
Author

sfaxon commented Sep 7, 2011

in production.rb I've got:
config.serve_static_assets = false

@spohlenz
Copy link
Owner

spohlenz commented Sep 7, 2011

I'm having trouble reproducing this. Are you able to upload a test app that exhibits the problem?

@sfaxon
Copy link
Author

sfaxon commented Sep 7, 2011

I just spent about an hour trying to reproduce this and can't. The app started being built agains 3.1.0rc1, I must have had an older dependency in there somewhere. Sorry for the false alarm.

@sfaxon sfaxon closed this Sep 7, 2011
@spohlenz
Copy link
Owner

spohlenz commented Sep 7, 2011

Not a problem. I'm going to release the 3.4.5 gem today so please let me know if you have any issues with that.

@digitalphotogallery
Copy link

I'm also seeing this issue. 3.4.4 is fine, but 3.4.5 breaks with:

rake aborted!
/usr/local/rvm/gems/ruby-1.9.2-p290/gems/tinymce-rails-3.4.5/assets/precompiled/tinymce/plugins/spellchecker/editor_plugin.js has a invalid UTF-8 byte sequence

@spohlenz spohlenz reopened this Sep 7, 2011
@spohlenz
Copy link
Owner

spohlenz commented Sep 7, 2011

@digitalphotogallery I'm not able to reproduce this. What is the value of config.serve_static_assets in production mode?

Can you upload a minimal app that has the issue?

@digitalphotogallery
Copy link

config.serve_static_assets = false

I'm going to try and create a clean application now to see if I can reproduce the problem.

@digitalphotogallery
Copy link

I found the cause. The issue was related to my application. I run scripts to deploy and one of them was running 'bundle exec rake assets:precompile RAILS_ENV=development' on the test server which was causing the rake to fail. In production 'bundle exec rake assets:precompile RAILS_ENV=production' works fine. Thank you for such a fast response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants