Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adding Provider defintion #517

Merged

Conversation

MovieStoreGuy
Copy link
Collaborator

Context

Extends #516

I realised that It isn't possible to migrate the current provider to use the provider meta since there is a lot of tight coupling to it. Therefore, I am going to go the other way and slowly migrate resources into the new provider and have that take over behind a environment variable so it becomes an option in feature.

Changes

  • Adding internal/definition/provider with test framework

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@03026c3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/definition/provider/provider.go 98.01% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage        ?   48.49%           
=======================================
  Files           ?       53           
  Lines           ?    10225           
  Branches        ?        0           
=======================================
  Hits            ?     4959           
  Misses          ?     5233           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MovieStoreGuy MovieStoreGuy merged commit 9f996c1 into splunk-terraform:main Oct 10, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@MovieStoreGuy MovieStoreGuy deleted the msg/add-provider-support branch October 14, 2024 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants