Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Creating dedicated resource definition for sfx_team #509

Merged

Conversation

MovieStoreGuy
Copy link
Collaborator

Context

The current library makes it hard to effectively isolate the required changes which introduces:

  • Lack of standards (since each method needs to be a new name due to symbol collisions)
  • Not easy to repeat practices
  • Hard to effectively test (unit, and acceptance)

Moving each resource to own package helps address some of the above concerns and allows in future to make it easier to include new functionality if required.

The expected package layout is the following:

internal/definition
└── <api>
    ├── [resource,data]{,_test,_acceptance_test}.go
    ├── schema{,_test}.go
    └── testdata
        └── <example>.tf       

Changes

  • Adds new package for team within definitions

@@ -1,6 +1,6 @@
module github.com/splunk-terraform/terraform-provider-signalfx

go 1.21
go 1.23
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly required to have http.NewServerMux work as intended

@MovieStoreGuy MovieStoreGuy marked this pull request as ready for review October 8, 2024 23:05
@MovieStoreGuy MovieStoreGuy merged commit aeec4fe into splunk-terraform:main Oct 8, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
@MovieStoreGuy MovieStoreGuy deleted the msg/port-team-resource branch October 14, 2024 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants