Feature: Add new package providermeta #506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Extends: #505
I wanted an easier way to provide the following:
The new package moves all the logic that currently exists in
signalfx/provider.go
into the new package which makes it possible use within unit tests without causing circular import issues.Changes
MetaProviderLookup
FileMetaLookup
,UserMetaLookup
, andNetrcMetaLookup
to align with the existing configuration process.LoadClient
andLoadApplicationURL
to reduce repeated code across the different resources.