Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retryable http client #416

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Add retryable http client #416

merged 5 commits into from
Feb 22, 2023

Conversation

dscott-splunk
Copy link
Collaborator

@dscott-splunk dscott-splunk commented Jan 31, 2023 •
edited
Loading

Adds configurable retry logic

@dscott-splunk dscott-splunk requested a review from keitwb as a code owner January 31, 2023 22:46
@dscott-splunk dscott-splunk marked this pull request as draft January 31, 2023 23:01
@dscott-splunk dscott-splunk marked this pull request as ready for review February 21, 2023 21:32
dloucasfx
dloucasfx requested changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@dloucasfx dloucasfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good; please see my comments.
Thanks !

signalfx/provider.go Outdated Show resolved Hide resolved
signalfx/provider.go Outdated Show resolved Hide resolved
dloucasfx
dloucasfx reviewed Feb 22, 2023
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@dloucasfx dloucasfx merged commit c6aaa01 into splunk-terraform:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dloucasfx dloucasfx dloucasfx approved these changes

@keitwb keitwb Awaiting requested review from keitwb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dscott-splunk @dloucasfx