Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix - adding color option to viz_options of table chart #410

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

rajeshkurup
Copy link
Contributor

SignalFX terraform provider version 6.20.0 throws following error while using table chart

Error: Invalid address to set: []string{"viz_options", "0", "color"}

│ with module.chart-test-dashboards.module.table-chart-test.signalfx_table_chart.chart0,
│ on ../../charts/table_charts/table-chart/main.tf line 1, in resource "signalfx_table_chart" "chart0":
│ 1: resource "signalfx_table_chart" "chart0" {

Though SignalFX UI does not support color for table chart, adding color to viz_options to fix above error.

@rajeshkurup rajeshkurup requested a review from keitwb as a code owner January 9, 2023 20:18
@rajeshkurup
Copy link
Contributor Author

rajeshkurup commented Jan 9, 2023

@keitwb Hi, Adding a bug fix to my PR (#402) which was release in version 6.20.0 - please help to release it ASAP - thanks!

@seonsfx seonsfx self-requested a review January 31, 2023 16:51
Copy link
Collaborator

@seonsfx seonsfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved.

@seonsfx
Copy link
Collaborator

seonsfx commented Jan 31, 2023

@rajeshkurup Could you resolve the conflict in CHANGELOG.md please? Thanks.

@rajeshkurup
Copy link
Contributor Author

Hi @seonsfx ,

Resolved the conflict in CHANGELOG.md.
Can you please help to merge and release this bug fix ASAP?

Thanks,
Rajesh

CHANGELOG.md Outdated Show resolved Hide resolved
@rajeshkurup
Copy link
Contributor Author

Hi @seonsfx ,

New version 6.22.0 has been added to CHANGELOG.md.

Thanks,
Rajesh

@seonsfx seonsfx merged commit 78c2db7 into splunk-terraform:main Jan 31, 2023
@seonsfx
Copy link
Collaborator

seonsfx commented Jan 31, 2023

@rajeshkurup This PR has been released with v6.22.0. Thank you again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants