Update group_type enum
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanrainwater
commented
Dec 21, 2023
| @@ -19,8 +19,12 @@ post: | |||
| type: string | |||
| group_type: | |||
| type: string | |||
| description: What is the group used for? | |||
| enum: [apartment, house, trip, other] | |||
| enum: [home, trip, couple, other, apartment, house] | |||
There was a problem hiding this comment.
- Moved
enumup. - Added
homeandcouple - Moved
apartmentandhouseto end of list
| description: What is the group used for? | ||
| enum: [apartment, house, trip, other] | ||
| enum: [home, trip, couple, other, apartment, house] | ||
| example: "home" |
There was a problem hiding this comment.
- Added example
| description: | | ||
| What is the group used for? | ||
| **Note**: It is recommended to use `home` in place of `house` or `apartment`. |
There was a problem hiding this comment.
- Added Note to description
| @@ -8,8 +8,12 @@ properties: | |||
| example: "Housemates 2020" | |||
| group_type: | |||
| type: string | |||
| enum: [apartment, house, trip, other] | |||
| example: "apartment" | |||
| enum: [home, trip, couple, other, apartment, house] | |||
There was a problem hiding this comment.
- Added
homeandcouple - Moved
apartmentandhouseto end of list
| enum: [apartment, house, trip, other] | ||
| example: "apartment" | ||
| enum: [home, trip, couple, other, apartment, house] | ||
| example: "home" |
There was a problem hiding this comment.
- Changed example from
apartmenttohome
| description: | | ||
| What is the group used for? | ||
| **Note**: It is recommended to use `home` in place of `house` or `apartment`. |
There was a problem hiding this comment.
- Added a description (copied from other example)
| @@ -277,7 +277,7 @@ tags: | |||
| - name: groups | |||
| x-displayName: Groups | |||
| description: | |||
| A Group represents a collection of users who share expenses together. For example, some users use a Group to aggregate expenses related to an apartment. Others use it to represent a trip. | |||
| A Group represents a collection of users who share expenses together. For example, some users use a Group to aggregate expenses related to a home. Others use it to represent a trip. | |||
There was a problem hiding this comment.
- Updated reference of
apartmenttohome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77. Updates references to
group_typeto includehomeandcouple. Also includes notes and updates references to preferhometoapartmentorhouse.