Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #534

Closed
wants to merge 71 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
2968a19
added undefined matcher flow
Mar 5, 2024
5cbe5dc
polish
Mar 5, 2024
c770cff
Merge pull request #510 from splitio/undefined-matcher
chillaq Mar 5, 2024
75cc222
added semver class
Mar 26, 2024
21f408b
polish
Mar 26, 2024
6b83afc
added equalto semver matcher
Mar 28, 2024
93d73b0
polish
Mar 28, 2024
45fbd0b
polish
Mar 28, 2024
8aa6bb9
added greater than or equal to semver matcher
Mar 28, 2024
30232f8
added less than or equal semver matcher
Mar 29, 2024
2f95e4b
added semver between matcher
Mar 29, 2024
2749c65
added in list semver matcher
Mar 29, 2024
7fd6f34
polish
Mar 29, 2024
e9677d9
fixed matcher logic
Apr 1, 2024
dc0caa6
fixed matcher logic
Apr 1, 2024
9f1b7d9
semver matchers integrations spec
Apr 1, 2024
8a1d214
Used csv for spec and added builder for semver class
Apr 8, 2024
f12ee2a
added csv files
Apr 8, 2024
acad113
updated using build for semver class
Apr 9, 2024
1e4a238
used build for semver class
Apr 9, 2024
8bf838b
used build for semver class
Apr 9, 2024
cf60f11
used build for semver class
Apr 9, 2024
61b8c9e
fixed condition
Apr 9, 2024
8cc7ff5
Merge pull request #514 from splitio/semver-class
chillaq Apr 10, 2024
f875912
Merge pull request #516 from splitio/semver-equalto-matcher
chillaq Apr 10, 2024
608c259
Merge pull request #517 from splitio/semver-greater-or-equalto-matcher
chillaq Apr 10, 2024
229a9f7
Merge pull request #518 from splitio/semver-less-or-equalto-matcher
chillaq Apr 10, 2024
89826a3
Merge pull request #519 from splitio/semver-between-matcher
chillaq Apr 10, 2024
f76b944
Merge pull request #521 from splitio/semver-integration-spec
chillaq Apr 10, 2024
980c272
added version attribute and used it in compare
Apr 10, 2024
b9e8fd8
updated semver spec
Apr 10, 2024
b1529d2
Fixed compare logic in semver, equalto and inlist matchers.
Apr 10, 2024
a8761d7
Added nil check for all matchers and updated specs
Apr 11, 2024
5a084a8
polish
Apr 11, 2024
a302223
Merge branch 'Feature/Semver' into semver-inlist-matcher
chillaq Apr 11, 2024
7ec5da7
added version length check for compare
Apr 11, 2024
4ecad51
correcting specs and comparisons
Apr 11, 2024
a1cab94
Merge pull request #525 from splitio/semver-inlist-matcher
chillaq Apr 11, 2024
fecd3b1
fixed occupancy publishers
sanzmauro Apr 17, 2024
f0b9c97
update spec
sanzmauro Apr 17, 2024
8ad8992
update notification manager
sanzmauro Apr 17, 2024
d90a18d
implementation
sanzmauro Apr 17, 2024
774ce4c
fixed spec
sanzmauro Apr 18, 2024
6804f26
Merge pull request #527 from splitio/sdks-8260-occupancy
sanzmauro Apr 18, 2024
0113765
Merge branch 'development' into unsupported-matcher
sanzmauro Apr 18, 2024
cecc9f3
Merge pull request #528 from splitio/unsupported-matcher
sanzmauro Apr 18, 2024
b2cfbcd
fixed posting data before shutdown
Apr 22, 2024
4406ef7
removed thwait lib
Apr 23, 2024
be09c7b
polish
Apr 23, 2024
bfaf1d2
polish
Apr 23, 2024
58512ba
added limit for joining thread
Apr 23, 2024
4c9e171
fixed join timeout
Apr 24, 2024
71320e2
Merge pull request #529 from splitio/post-data-destroy
chillaq Apr 24, 2024
a0a6055
added spec query parameter
Apr 24, 2024
796014b
Merge branch 'development' into semver-spec-query
chillaq Apr 24, 2024
fd4eb7d
fix specs
Apr 24, 2024
ab10e30
moved spec constant to nw spec module
Apr 25, 2024
7cb1c31
new spec module
Apr 25, 2024
6eafede
Merge pull request #530 from splitio/semver-spec-query
chillaq Apr 26, 2024
0f5ac2f
Merge branch 'development' into Feature/Semver
chillaq May 1, 2024
db9311a
updated query api order, fixed spec and added error to split logger
May 1, 2024
418e5d7
added debug to split logger
May 1, 2024
b7ecdd1
update debug logging in semver matchers
May 1, 2024
1bc71a5
fixed spec
May 1, 2024
abea9d2
polishing
May 1, 2024
581d6e3
polish
May 1, 2024
50fe596
polish
May 2, 2024
2a54d08
polish and test update
May 2, 2024
91b9266
Merge pull request #532 from splitio/Feature/Semver
chillaq May 2, 2024
9299411
release 8.4.0
May 2, 2024
496265d
Merge pull request #533 from splitio/release-8.4.0
chillaq May 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed thwait lib
Bilal Al committed Apr 23, 2024
commit 4406ef7b4dc2b4a4077aeb391cdca913bd8aea8e
7 changes: 1 addition & 6 deletions lib/splitclient-rb/clients/split_client.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
require 'thread'
require 'thwait'

module SplitIoClient
EVENTS_SIZE_THRESHOLD = 32768
EVENT_AVERAGE_SIZE = 1024
@@ -104,9 +101,7 @@ def destroy
@config.logger.debug("Impressions and/or Events cache is not empty")
if [email protected]?(:impressions_sender) && [email protected]?(:events_sender)
@config.logger.debug("Periodic data recording thread has not started yet, waiting for service startup.")
threads = []
threads << @config.threads[:start_sdk]
ThreadsWait.all_waits(*threads)
@config.threads[:start_sdk].join
end
end
@config.threads.select { |name, thread| name.to_s.end_with? 'sender' }.values.each do |thread|