fix: prevent shutdown from hanging forever #494
Conversation
`rescue StandardError` is a common idiom to prevent errors from stopping long running processes. To prevent `SDKShutdownException` from being silently eaten by such a `rescue` we should not inherit from `StandardError`.
|
I don't understand the CI failures. Can someone tell me how to fix them? |
|
Hi @docwhat, I will take a look at the changes and failures. cc @agustinona |
|
@sanzmauro thanks for taking a look! Do we happen to have an update here? |
|
@chillaq Hello! Please let me know why you removed my name and comment from commit 6d3a3fc. I followed the contribution instructions, filled out the PR template, and made sure to document (as a comment) why I violated Ruby best practices by not using Please tell me if I did something wrong so I can fix it. This tiny change (one word) took around 16 hours of analyzing the code and reading the git history to understand the source of this randomly happening bug. And over 10 years of Ruby experience. On your end, this bug impacted every customer who ever used the Ruby client. I can't begin to guess the cost in time and money to your company and your customers. I use my contributions on GitHub as a portfolio to get work and contribute to other open-source projects. Please consider restoring me as the "author" of commit 6d3a3fc. You can do that by restoring the original commit message from 37ef0cb or by forcing the author with the |
Ruby SDK
What did you accomplish?
I prevented
SDKShutdownExceptionfrom being silently eaten byrescue StandardError, littered throughout the code.If eaten by a thread then that thread will never be able to
thread.joinand will hang forever.How to test new changes?
Do you have ideas?
Extra Notes
I ran across this problem in 7.0.3 where
def post_metricscaught and threw awaySDKShutdownException.This is still a potential problem in the current version, 8.2.0.