Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagset evaluator refactor #493

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

chillaq
Copy link
Contributor

@chillaq chillaq commented Nov 10, 2023

Ruby SDK

What did you accomplish?

How to test new changes?

Extra Notes

@chillaq chillaq requested a review from a team as a code owner November 10, 2023 19:33
@chillaq chillaq requested a review from sanzmauro November 10, 2023 19:33
@chillaq chillaq requested a review from sanzmauro November 13, 2023 19:57
Copy link
Contributor

@sanzmauro sanzmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you running rubocop before pushing? I am getting 10 offenses detected and 6 offenses auto-correctable

@chillaq chillaq requested a review from sanzmauro November 14, 2023 20:07
@chillaq chillaq merged commit 5be6722 into Feature/flag-sets-base Nov 16, 2023
@chillaq chillaq deleted the flagset-evaluator-refactor branch November 16, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants