Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlagSets support #20

Merged
merged 36 commits into from
Jan 25, 2024
Merged

FlagSets support #20

merged 36 commits into from
Jan 25, 2024

Conversation

mmelograno
Copy link
Contributor

@mmelograno mmelograno commented Jan 12, 2024 •
edited
Loading

  • Added getTreatmentsByFlagSet, getTreatmentsWithConfigByFlagSet, getTreatmentsByFlagSets, getTreatmentsWithConfigByFlagSets method.
  • Added cache for flagSets.

@mmelograno
Merge branch 'main' of github.com:splitio/php-thin-client
e2db61a
@mmelograno
added support to treatmentsByFlagSet
95da73f
@mmelograno
Merge branch 'main' of github.com:splitio/php-thin-client into task/t…
847f160 
…reatmentsByFlagSet
@mmelograno
fixes
44be35d
@mmelograno
added testing coverage
54870d6
@mmelograno
added treatmentsByFlagSets
8e8f1f5
@mmelograno
added support to sets and defaultTreatment in manager
67568f0
@mmelograno
Merge branch 'main' of github.com:splitio/php-thin-client
cdc76c9
@mmelograno
added tracer
a774876
@mmelograno
Merge pull request #17 from splitio/task/treatmentsByFlagSet
d4077d0 
Task/treatments by flag set
@mmelograno
Merge branch 'task/flagSets' of github.com:splitio/php-thin-client in…
c9c15bf 
…to task/treatmentsByFlagSets
@mmelograno
added tracer
e86e397
@mmelograno
Merge branch 'task/flagSets' of github.com:splitio/php-thin-client in…
e9e14ff 
…to task/managerflagsets
@mmelograno
Merge pull request #18 from splitio/task/treatmentsByFlagSets
e617b6b 
Task/treatments by flag sets
@mmelograno
Merge branch 'task/flagSets' of github.com:splitio/php-thin-client in…
17e231c 
…to task/managerflagsets
@mmelograno
Merge pull request #19 from splitio/task/managerflagsets
d9a8934 
Added `defaultTreatment` and `sets` into Manager
@mmelograno
added cache for bySet evaluation
1265288
@mmelograno
Merge branch 'task/flagSets' of github.com:splitio/php-thin-client in…
b9271b1 
…to task/flagSetsCache
@mmelograno
added cache for flagsets
b10f8d0
@mmelograno
added some comments
29f8580
@mmelograno
updated cache methods for flagsets
08479a0
@mmelograno
removed unused assert
91b2a6d
@mmelograno
Merge pull request #21 from splitio/task/flagSetsCache
8abebc2 
Added cache methods for flagSets
@mmelograno
added validation for flagsets
814dc0a
@mmelograno
removed duplicates
63c8f27
@mmelograno
added delimiters to refer to logs for flagsets for input passed
2f4adc5
@mmelograno
added empty array in case cache returns null
cfed211
@mmelograno
added coverage for cache and manager;
f0509d9
@mmelograno
Merge pull request #22 from splitio/task/inputValidation
2682ee9 
Added inputValidation to flagSets
@mmelograno
Merge branch 'task/flagSets' of github.com:splitio/php-thin-client in…
8a844e6 
…to task/flagSets
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 3.1% 3.14% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@mmelograno mmelograno changed the title Task/flag sets FlagSets support Jan 25, 2024
@mmelograno mmelograno requested a review from a team January 25, 2024 16:42
@mmelograno mmelograno merged commit 5332009 into main Jan 25, 2024
3 of 4 checks passed
@mmelograno mmelograno deleted the task/flagSets branch January 25, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mredolatti mredolatti mredolatti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmelograno @mredolatti