fixes

splitio · Dec 28, 2023 · 44be35d · 44be35d
1 parent 847f160
commit 44be35d
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 11 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -156,8 +156,12 @@ public function getTreatmentsWithConfig(string $key, ?string $bucketingKey, arra
         }
     }
 
-    public function getTreatmentsByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes): array
-    {
+    public function getTreatmentsByFlagSet(
+        string $key,
+        ?string $bucketingKey,
+        string $flagSet,
+        ?array $attributes
+    ): array {
         try {
             // @TODO implement cache for this method
 
@@ -175,8 +179,12 @@ public function getTreatmentsByFlagSet(string $key, ?string $bucketingKey, strin
         }
     }
 
-    public function getTreatmentsWithConfigByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes = null): array
-    {
+    public function getTreatmentsWithConfigByFlagSet(
+        string $key,
+        ?string $bucketingKey,
+        string $flagSet,
+        ?array $attributes = null
+    ): array {
         try {
             // @TODO implement cache for this method
 

diff --git a/src/ClientInterface.php b/src/ClientInterface.php
@@ -9,6 +9,11 @@ function getTreatmentWithConfig(string $key, ?string $bucketingKey, string $feat
     function getTreatments(string $key, ?string $bucketingKey, array $features, ?array $attributes): array;
     function getTreatmentsWithConfig(string $key, ?string $bucketingKey, array $features, ?array $attributes): array;
     function getTreatmentsByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes): array;
-    function getTreatmentsWithConfigByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes): array;
+    function getTreatmentsWithConfigByFlagSet(
+        string $key,
+        ?string $bucketingKey,
+        string $flagSet,
+        ?array $attributes
+    ): array;
     function track(string $key, string $trafficType, string $eventType, ?float $value = null, ?array $properties = null): bool;
 }
diff --git a/src/Link/Consumer/Manager.php b/src/Link/Consumer/Manager.php
@@ -11,7 +11,12 @@ function getTreatmentWithConfig(string $key, ?string $bucketingKey, string $feat
     function getTreatments(string $key, ?string $bucketingKey, array $features, ?array $attributes): array;
     function getTreatmentsWithConfig(string $key, ?string $bucketingKey, array $features, ?array $attributes): array;
     function getTreatmentsByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes): array;
-    function getTreatmentsWithConfigByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes): array;
+    function getTreatmentsWithConfigByFlagSet(
+        string $key,
+        ?string $bucketingKey,
+        string $flagSet,
+        ?array $attributes
+    ): array;
     function track(string $key, string $trafficType, string $eventType, ?float $value, ?array $properties): bool;
     function splitNames(): array;
     function split(string $splitName): ?SplitView;

diff --git a/src/Link/Consumer/V1Manager.php b/src/Link/Consumer/V1Manager.php
@@ -114,16 +114,20 @@ public function getTreatmentsByFlagSet(string $key, ?string $bucketingKey, strin
     }
 
 
-    public function getTreatmentsWithConfigByFlagSet(string $key, ?string $bucketingKey, string $flagSet, ?array $attributes): array
-    {
+    public function getTreatmentsWithConfigByFlagSet(
+        string $key,
+        ?string $bucketingKey,
+        string $flagSet,
+        ?array $attributes
+    ): array {
         $response = Protocol\V1\TreatmentsByFlagSetResponse::fromRaw(
             $this->rpcWithReconnect(RPC::forTreatmentsWithConfigByFlagSet($key, $bucketingKey, $flagSet, $attributes))
         );
         $response->ensureSuccess();
 
         $results = [];
 
-        foreach($response->getEvaluationResults() as $feature=>$evalResult) {
+        foreach ($response->getEvaluationResults() as $feature => $evalResult) {
             $results[$feature] = $evalResult == null
             ? ["control", null, null]
             : [$evalResult->getTreatment(), $evalResult->getImpressionListenerdata(), $evalResult->getConfig()];

diff --git a/src/Link/Protocol/V1/TreatmentsByFlagSetArgs.php b/src/Link/Protocol/V1/TreatmentsByFlagSetArgs.php
@@ -20,6 +20,4 @@ class TreatmentsByFlagSetArgs extends Enum
     private const BUCKETING_KEY = 1;
     private const FLAG_SET = 2;
     private const ATTRIBUTES = 3;
-
 }
-