Merge pull request #818 from splitio/SDKS-8407_unify_endpoint

Large segments refactors: remove configs and unify endpoint

CHANGES.txt

@@ -1,3 +1,8 @@
+10.29.0 (September XX, 2024)
+ - Updated @splitsoftware/splitio-commons package to version 1.18.0 that includes minor updates:
+    - Added support for targeting rules based on large segments for browsers.
+    - Updated some transitive dependencies for vulnerability fixes.
+
 10.28.0 (September 6, 2024)
  - Updated @splitsoftware/splitio-commons package to version 1.17.0 that includes minor updates:
     - Added `sync.requestOptions.getHeaderOverrides` configuration option to enhance SDK HTTP request Headers for Authorization Frameworks.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio",
-  "version": "10.28.0",
+  "version": "10.28.1-rc.0",
   "description": "Split SDK",
   "files": [
     "README.md",
@@ -40,7 +40,7 @@
     "node": ">=6"
   },
   "dependencies": {
-    "@splitsoftware/splitio-commons": "1.17.0",
+    "@splitsoftware/splitio-commons": "1.17.1-rc.0",
     "@types/google.analytics": "0.0.40",
     "@types/ioredis": "^4.28.0",
     "bloom-filters": "^3.0.0",

src/__tests__/browserSuites/evaluations-semver.spec.js

@@ -27,8 +27,8 @@ export default async function (fetchMock, assert) {
 
   fetchMock.getOnce(config.urls.sdk + '/splitChanges?s=1.2&since=-1', { status: 200, body: splitChangesMock1 });
   fetchMock.getOnce(config.urls.sdk + '/splitChanges?s=1.2&since=1675259356568', { status: 200, body: { splits: [], since: 1675259356568, till: 1675259356568 } });
-  fetchMock.getOnce(config.urls.sdk + '/mySegments/emi%40split.io', { status: 200, body: { mySegments: [] } });
-  fetchMock.getOnce(config.urls.sdk + '/mySegments/2nd', { status: 200, body: { mySegments: [] } });
+  fetchMock.getOnce(config.urls.sdk + '/memberships/emi%40split.io', { status: 200, body: { ms: {} } });
+  fetchMock.getOnce(config.urls.sdk + '/memberships/2nd', { status: 200, body: { ms: {} } });
 
   const splitio = SplitFactory(config);
   const client = splitio.client();

src/__tests__/browserSuites/evaluations.spec.js

@@ -365,7 +365,7 @@ export default function (config, fetchMock, assert) {
   for (i; i < SDK_INSTANCES_TO_TEST; i++) {
     let splitio = SplitFactory(config);
 
-    fetchMock.getOnce('https://sdk.split.io/api/mySegments/aaaaaaklmnbv', { status: 200, body: { mySegments: [] } });
+    fetchMock.getOnce('https://sdk.split.io/api/memberships/aaaaaaklmnbv', { status: 200, body: { ms: {} } });
 
     // on TA tests, this is going to return one against the mocked seed.
     let clientTABucket1 = splitio.client('aaaaaaklmnbv');

src/__tests__/browserSuites/fetch-specific-splits.spec.js

@@ -33,7 +33,7 @@ export function fetchSpecificSplits(fetchMock, assert) {
         });
         return { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } };
       });
-      fetchMock.get(urls.sdk + '/mySegments/nicolas%40split.io', { status: 200, body: { 'mySegments': [] } });
+      fetchMock.get(urls.sdk + '/memberships/nicolas%40split.io', { status: 200, body: { 'ms': {} } });
 
       factory = SplitFactory(config);
 
@@ -68,7 +68,7 @@ export function fetchSpecificSplitsForFlagSets(fetchMock, assert) {
 
     let factory;
     const queryString = '&sets=4_valid,set_2,set_3,set_ww,set_x';
-    fetchMock.get(baseUrls.sdk + '/mySegments/nicolas%40split.io', { status: 200, body: { 'mySegments': [] } });
+    fetchMock.get(baseUrls.sdk + '/memberships/nicolas%40split.io', { status: 200, body: { 'ms': {} } });
 
     fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1' + queryString, { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 }});
     fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1457552620999' + queryString, async function () {

src/__tests__/browserSuites/flag-sets.spec.js

@@ -17,7 +17,7 @@ const baseConfig = {
 };
 
 export default function flagSets(fetchMock, t) {
-  fetchMock.get(baseUrls.sdk + '/mySegments/nicolas%40split.io', { status: 200, body: { 'mySegments': [] } });
+  fetchMock.get(baseUrls.sdk + '/memberships/nicolas%40split.io', { status: 200, body: { 'ms': {} } });
 
   t.test(async (assert) => {
     let factory;
@@ -135,7 +135,7 @@ export default function flagSets(fetchMock, t) {
 
     let factory, client = [];
 
-    fetchMock.get(baseUrls.sdk + '/mySegments/nicolas%40split.io', { status: 200, body: { 'mySegments': [] } });
+    fetchMock.get(baseUrls.sdk + '/memberships/nicolas%40split.io', { status: 200, body: { 'ms': {} } });
     // Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
     fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1&sets=set_1',  function () {
       return { status: 200, body: splitChange2};
@@ -172,7 +172,7 @@ export default function flagSets(fetchMock, t) {
 
     let factory, client = [];
 
-    fetchMock.get(baseUrls.sdk + '/mySegments/nicolas%40split.io', { status: 200, body: { 'mySegments': [] } });
+    fetchMock.get(baseUrls.sdk + '/memberships/nicolas%40split.io', { status: 200, body: { 'ms': {} } });
     // Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
     fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1',  function () {
       return { status: 200, body: splitChange2};

src/__tests__/browserSuites/ignore-ip-addresses-setting.spec.js

@@ -103,7 +103,7 @@ export default function (fetchMock, assert) {
     const settings = settingsFactory(config);
     fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
     fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } });
-    fetchMock.getOnce(url(settings, `/mySegments/${encodeURIComponent(config.core.key)}`), { status: 200, body: { mySegments: [] } });
+    fetchMock.getOnce(url(settings, `/memberships/${encodeURIComponent(config.core.key)}`), { status: 200, body: { ms: {} } });
 
     // Init Split client
     const splitio = SplitFactory(config);

src/__tests__/browserSuites/impressions.debug.spec.js

@@ -2,7 +2,7 @@ import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';
 import splitChangesMock1 from '../mocks/splitchanges.since.-1.json';
 import splitChangesMock2 from '../mocks/splitchanges.since.1457552620999.json';
-import mySegmentsFacundo from '../mocks/mysegments[email protected]';
+import membershipsFacundo from '../mocks/memberships[email protected]';
 import { DEBUG } from '@splitsoftware/splitio-commons/src/utils/constants';
 import { url } from '../testUtils';
 
@@ -23,7 +23,7 @@ export default function (fetchMock, assert) {
   // Mocking this specific route to make sure we only get the items we want to test from the handlers.
   fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
   fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
-  fetchMock.get(url(settings, '/mySegments/facundo%40split.io'), { status: 200, body: mySegmentsFacundo });
+  fetchMock.get(url(settings, '/memberships/facundo%40split.io'), { status: 200, body: membershipsFacundo });
 
   const splitio = SplitFactory({
     core: {

src/__tests__/browserSuites/impressions.none.spec.js

@@ -2,7 +2,7 @@ import { SplitFactory } from '../..';
 import { settingsFactory } from '../../settings/node';
 import splitChangesMock1 from '../mocks/splitchanges.since.-1.json';
 import splitChangesMock2 from '../mocks/splitchanges.since.1457552620999.json';
-import mySegmentsFacundo from '../mocks/mysegments[email protected]';
+import membershipsFacundo from '../mocks/memberships[email protected]';
 import { NONE } from '@splitsoftware/splitio-commons/src/utils/constants';
 import { truncateTimeFrame } from '@splitsoftware/splitio-commons/src/utils/time';
 import { url } from '../testUtils';
@@ -43,8 +43,8 @@ export default async function (fetchMock, assert) {
   // Mocking this specific route to make sure we only get the items we want to test from the handlers.
   fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
   fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
-  fetchMock.get(url(settings, '/mySegments/facundo%40split.io'), { status: 200, body: mySegmentsFacundo });
-  fetchMock.get(url(settings, '/mySegments/emma%40split.io'), { status: 200, body: mySegmentsFacundo });
+  fetchMock.get(url(settings, '/memberships/facundo%40split.io'), { status: 200, body: membershipsFacundo });
+  fetchMock.get(url(settings, '/memberships/emma%40split.io'), { status: 200, body: membershipsFacundo });
 
   const splitio = SplitFactory(config);
   const client = splitio.client();

src/__tests__/browserSuites/impressions.spec.js

@@ -2,7 +2,7 @@ import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';
 import splitChangesMock1 from '../mocks/splitchanges.since.-1.json';
 import splitChangesMock2 from '../mocks/splitchanges.since.1457552620999.json';
-import mySegmentsFacundo from '../mocks/mysegments[email protected]';
+import membershipsFacundo from '../mocks/memberships[email protected]';
 import { OPTIMIZED } from '@splitsoftware/splitio-commons/src/utils/constants';
 import { truncateTimeFrame } from '@splitsoftware/splitio-commons/src/utils/time';
 import { url } from '../testUtils';
@@ -26,7 +26,7 @@ export default function (fetchMock, assert) {
   // Mocking this specific route to make sure we only get the items we want to test from the handlers.
   fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
   fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
-  fetchMock.get(url(settings, '/mySegments/facundo%40split.io'), { status: 200, body: mySegmentsFacundo });
+  fetchMock.get(url(settings, '/memberships/facundo%40split.io'), { status: 200, body: membershipsFacundo });
 
   const splitio = SplitFactory({
     core: {

src/__tests__/browserSuites/push-corner-cases.spec.js

@@ -37,8 +37,8 @@ const MILLIS_SPLIT_CHANGES_RESPONSE = 400;
 
 /**
  * Sequence of calls:
- *  0.0 secs: initial SyncAll (/splitChanges, /mySegments/*), auth, SSE connection, SDK_READY_FROM_CACHE
- *  0.1 secs: SSE connection opened -> syncAll (/splitChanges, /mySegments/*)
+ *  0.0 secs: initial SyncAll (/splitChanges, /memberships/*), auth, SSE connection, SDK_READY_FROM_CACHE
+ *  0.1 secs: SSE connection opened -> syncAll (/splitChanges, /memberships/*)
  *  0.2 secs: SPLIT_KILL event -> /splitChanges
  *  0.4 secs: /splitChanges response --> SDK_READY
  */
@@ -72,8 +72,8 @@ export function testSplitKillOnReadyFromCache(fetchMock, assert) {
 
   // 1 auth request
   fetchMock.getOnce(url(settings, `/v2/auth?s=1.2&users=${encodeURIComponent(userKey)}`), { status: 200, body: authPushEnabledNicolas });
-  // 2 mySegments requests: initial sync and after SSE opened
-  fetchMock.get({ url: url(settings, '/mySegments/nicolas%40split.io'), repeat: 2 }, { status: 200, body: { mySegments: [] } });
+  // 2 memberships requests: initial sync and after SSE opened
+  fetchMock.get({ url: url(settings, '/memberships/nicolas%40split.io'), repeat: 2 }, { status: 200, body: { ms: {} } });
 
   // 2 splitChanges request: initial sync and after SSE opened. Sync after SPLIT_KILL is not performed because SplitsSyncTask is "executing"
   fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=25'), { status: 200, body: splitChangesMock1 }, { delay: MILLIS_SPLIT_CHANGES_RESPONSE, /* delay response */ });