Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post review changes #548

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Post review changes #548

merged 7 commits into from
Oct 27, 2023

Conversation

gthea
Copy link
Contributor

@gthea gthea commented Oct 27, 2023

Android SDK

What did you accomplish?

  • Used Guava's Sets.intersection method
  • Started to return empty map as result of evaluations by flag sets performed when the client has been destroyed
  • Stopped modifying the sets from stored feature flags
  • Added warning logs displayed when evaluating with invalid sets

@gthea gthea self-assigned this Oct 27, 2023
@gthea gthea marked this pull request as ready for review October 27, 2023 21:19
@gthea gthea requested a review from a team as a code owner October 27, 2023 21:19
@gthea gthea merged commit b671826 into SDKS-7440 Oct 27, 2023
5 checks passed
@gthea gthea deleted the sets_review branch October 27, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees

@gthea gthea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gthea @sanzmauro