Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ViewModel to LifecycleViewModel #558

Closed
dasdranagon opened this issue Aug 30, 2022 · 1 comment · Fixed by #570
Closed

Rename ViewModel to LifecycleViewModel #558

dasdranagon opened this issue Aug 30, 2022 · 1 comment · Fixed by #570
Assignees
Labels

Comments

@dasdranagon
Copy link
Contributor

Why

Currently, the name of ViewModel is a bit confusing and doesn't explicitly describe what it does. In fact, it makes an impression that the class is meant to be used as a parent for all view models. However, it is meant to be used to manage the lifecycle and you don't have to (and shouldn't) use it on all your screen.

Because we are already using ViewModel in most of our projects it makes sense to create an alias and mark it as deprecated before actually deleting it.

@dasdranagon dasdranagon self-assigned this Aug 30, 2022
@dasdranagon dasdranagon added the 1.x.x expected somewhere in a future release label Aug 30, 2022
@thoutbeckers
Copy link
Collaborator

Discussed in kaluga meeting to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants