Support Kotlin 1.9.20 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-sdk Bump Firebase Android BoM to 32.3.1
Daeda88
force-pushed
the
feature/kotlin-1.9.20
branch
from
252dd7e to
ccb5561
Compare
dasdranagon
approved these changes
Nov 14, 2023
thoutbeckers
approved these changes
Nov 14, 2023
avdyushin
reviewed
Nov 14, 2023
| @@ -38,7 +38,7 @@ suspend fun <T> Task<T>.awaitWhileOnline(database: FirebaseDatabase): T = | |||
| .reference(".info/connected") | |||
| .valueEvents | |||
| .debounce(2.seconds) | |||
| .filter { !it.value<Boolean>() } | |||
| .filterNot { it.value<Boolean>() } | |||
There was a problem hiding this comment.
To be fair, this is from the upstream :P
avdyushin
reviewed
Nov 14, 2023
| check(Firebase.auth.currentUser != null) | ||
| Firebase.auth.signOut() | ||
| check(Firebase.auth.currentUser == null) | ||
| check(auth.currentUser != null) |
There was a problem hiding this comment.
BTW, what is check compare to assertNull?
There was a problem hiding this comment.
Here is also checkNotNull available in anycase :)
…odeUserTokenExpired handle FIRAuthErrorCodeUserTokenExpired
This reverts commit 326a7cd.
This reverts commit e709dd3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.