Replace use of r2d2 with redis-rs ConnectionManager #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfittl
force-pushed
the
connection-manager
branch
from
feb8366 to
9292230
Compare
Using r2d2 with redis isn't really necessary, as the redis crate can multiplex a connection, and in fact its the recommended approach for most use cases: redis-rs/redis-rs#388 (comment) Therefore this changes things to use redis-rs internally, with the intent of adding an async API to this crate in the future. Additionally this enables TLS for Redis connections, to support Redis servers that require TLS. This change is mostly API-compatible, but does change the underlying RedisPool type (its still called "pool", but its actually a ConnectionManager), and drops the exported type RedisPooledConnection.
lfittl
force-pushed
the
connection-manager
branch
from
9292230 to
8b1f259
Compare
This otherwise errors out with an error like this, since you can't use block_on inside another block_on: "cannot execute `LocalPool` executor from within another executor"
lfittl
force-pushed
the
connection-manager
branch
from
8547860 to
8a85a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using r2d2 with redis isn't really necessary, as the redis crate can
multiplex a connection, and in fact its the recommended approach for most
use cases: redis-rs/redis-rs#388 (comment)
Therefore this changes things to use redis-rs internally, with the intent
of adding an async API to this crate in the future. Additionally this
enables TLS for Redis connections, to support Redis servers that require
TLS.
This change is mostly API-compatible, but does change the underlying
RedisPool type (its still called "pool", but its actually a
ConnectionManager), and drops the exported type RedisPooledConnection.