Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rates inside transaction, to prevent RC issues #66

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Update rates inside transaction, to prevent RC issues #66

merged 1 commit into from
Sep 11, 2020

Conversation

korun
Copy link
Contributor

@korun korun commented Sep 11, 2020

Without explicit transaction call, Thread#1 can clear good rate, which was set by Thread#2 moment ago.

Refs #63 and #64 (comment)

@korun
Update rates inside transaction, to prevent RC issues
c288585 
Without explicit transaction call, Thread#1 can clear good rate, which was set by Thread#2 moment ago
@korun korun mentioned this pull request Sep 11, 2020
Merged
spk
spk approved these changes Sep 11, 2020
View reviewed changes
Copy link
Owner

@spk spk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spk spk merged commit c720104 into spk:master Sep 11, 2020
@korun korun deleted the clear-cross-courses branch September 11, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spk spk spk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korun @spk