Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for symbols query param #52

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

thejchap
Copy link
Contributor

@thejchap thejchap commented May 9, 2018

No description provided.

@coveralls
Copy link

coveralls commented May 9, 2018

Pull Request Test Coverage Report for Build 220

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.4%) to 95.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/money/bank/open_exchange_rates_bank.rb 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
lib/money/bank/open_exchange_rates_bank.rb 2 97.01%
Totals Coverage Status
Change from base Build 219: -4.4%
Covered Lines: 130
Relevant Lines: 136

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 220

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.4%) to 95.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/money/bank/open_exchange_rates_bank.rb 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
lib/money/bank/open_exchange_rates_bank.rb 2 97.01%
Totals Coverage Status
Change from base Build 219: -4.4%
Covered Lines: 130
Relevant Lines: 136

💛 - Coveralls

@spk
Copy link
Owner

spk commented Jan 9, 2019

Hi @thejchap sorry for the delay there is rubocop offence on source_url but I will fix it on another commit thanks

@spk spk merged commit de5d334 into spk:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants