Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Float casting for BigDecimal #46

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Fix issue with Float casting for BigDecimal #46

merged 1 commit into from
Mar 27, 2018

Conversation

cedricpim
Copy link
Contributor

Fixes #45.

When the rate is a Float, we are trying to cast it to BigDecimal but BigDecimal is not capable of doing it so we need to cast it to String first.

@cedricpim
Copy link
Contributor Author

@spk please take a look :)

@cedricpim cedricpim force-pushed the fix-float-big-decimal-casting branch from 69fa08e to f7dd615 Compare March 26, 2018 15:07
@b-mandelbrot
Copy link
Contributor

@cedricpim I have the same problem here. Cast it to String or set precision according to the currency. I think String is ok.

spk
spk approved these changes Mar 27, 2018
View reviewed changes
Copy link
Owner

@spk spk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spk spk merged commit b2706fd into spk:master Mar 27, 2018
@cedricpim cedricpim deleted the fix-float-big-decimal-casting branch May 30, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spk spk spk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedricpim @b-mandelbrot @spk