Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PROPOSAL) 2-layers cache Documentation #48

Closed
tonidas opened this issue Mar 28, 2018 · 3 comments
Closed

(PROPOSAL) 2-layers cache Documentation #48

tonidas opened this issue Mar 28, 2018 · 3 comments

Comments

@tonidas
Copy link

tonidas commented Mar 28, 2018

I think that the documentation should talk about the two layers of cache that the gem provides:

  1. The memory cache layer
  2. The custom cache layer

It's very confusing at first, because there is two TTLs, the one related to the memory cache layer (native) and the one related to the custom cache layer (optional).

I can do that if the contributors agree that this is relevant.

Cheers

@spk
Copy link
Owner

spk commented Mar 31, 2018

Yes sure if you think it need improvement pull request are welcome @tonidas cheers

@spk
Copy link
Owner

spk commented Apr 15, 2018

There is more information on the PR linked; feel free to submit a PR if its still not clear

@spk spk closed this as completed Apr 15, 2018
@simshanith
Copy link

To clarify, the "custom" cache is used to cache the HTTP response from Open Exchange Rates. The other store is an "Exchange Rates Store" with interface defined by the Money gem, as mentioned in several spots in the docs.

https://github.com/RubyMoney/money#exchange-rate-stores

This distinction is important in understanding why both are necessary - they cache different things with different interfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants