Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate secure_connection option #39

Closed
jaredmoody opened this issue Feb 4, 2018 · 1 comment
Closed

Deprecate secure_connection option #39

jaredmoody opened this issue Feb 4, 2018 · 1 comment

Comments

@jaredmoody
Copy link
Contributor

From the documentation, it seems that all requests now can be served over https, even on free plans.

So how about deprecating the secure_connection option and always using https? Or at the very least default to https and allow an option to turn https off?

I'd be happy to submit a PR if you like the idea.
@spk
Copy link
Owner

spk commented Feb 21, 2018

Yes sure PR are welcome; thanks

@spk spk closed this as completed in 444ce0d Mar 23, 2018
spk added a commit that referenced this issue Mar 23, 2018
@spk
Merge pull request #40 from Jetbuilt/deprecate-secure_connection
f26edd5 
Closes #39 - Make all requests over https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredmoody @spk