I/O Driver #1897
Merged
I/O Driver #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to unblock the DataFusion prototype, but will queue this up for a proper review if it turns out to be a useful component. |
robert3005
reviewed
Jan 13, 2025
Comment on lines
+78
to
+86
| // TODO(ngates): we should call buffered(n) on this stream so that is launches multiple | ||
| // splits to run in parallel. Currently we use block_on, so there's no point this being | ||
| // any higher than the size of the thread pool. If we switch to running LocalExecutor, | ||
| // then there may be some value in slightly over-subscribing. | ||
|
|
||
| // Set up an I/O driver that will make progress on 32 I/O requests at a time. | ||
| // TODO(ngates): we should probably have segments hold an Arc'd driver stream internally | ||
| // so that multiple scans can poll it, while still sharing the same global concurrency | ||
| // limit? |
There was a problem hiding this comment.
Seems these two comments are not in sync
Comment on lines
+58
to
+70
| // Launch the scan task onto the thread pool. | ||
| self.thread_pool.spawn_fifo(move || { | ||
| let array_result = | ||
| range_scan.and_then(|range_scan| { | ||
| block_on(range_scan.evaluate_async(|row_mask, expr| { | ||
| reader.evaluate_expr(row_mask, expr) | ||
| })) | ||
| }); | ||
| // Post the result back to the main thread | ||
| send.send(array_result) | ||
| .map_err(|_| vortex_err!("send failed, recv dropped")) | ||
| .vortex_expect("send_failed, recv dropped"); | ||
| }); |
There was a problem hiding this comment.
Why not par iter on the thread_pool?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a basic implementation of an I/O driver so we can hook the new layouts up to DataFusion which requires sendable record batch streams.