Field::Index to Field::Name expr transform #1894
Open
+155
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-isaacs
force-pushed
the
ji/field-idx-to-name
branch
from
8bcc791 to
4697fb0
Compare
gatesn
reviewed
Jan 10, 2025
| use crate::traversal::{MutNodeVisitor, Node, TransformResult}; | ||
| use crate::{ExprRef, GetItem}; | ||
|
|
||
| pub struct FieldToNameTransform { |
There was a problem hiding this comment.
Can you write a doc string please. And also one for new since it's not obvious to me what ident_dt means? It's too abbreviated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.