Into arrow with hint #1730
Merged
Into arrow with hint #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt to a target arrow data_type
joseph-isaacs
force-pushed
the
ji/into-arrow-with-hint
branch
from
603142b to
b0de02d
Compare
gatesn
reviewed
Jan 2, 2025
| // Note, arrow::cast clones the array, so don't use it if unnecessary. | ||
| Ok(match data_type { | ||
| DataType::Binary | DataType::LargeBinary | DataType::Utf8 | DataType::LargeUtf8 => { | ||
| array_ref |
There was a problem hiding this comment.
This doesn't make much sense to me. You switch on the requested data type, then you return whatever into_arrow returns without checking the data_type actually matches?
Shouldn't it be more like if array_ref.data_type() != data_type { array_ref = cast(...) }
gatesn
approved these changes
Jan 3, 2025
| fn into_arrow(self) -> VortexResult<ArrayRef> { | ||
| fn into_arrow(self) -> VortexResult<ArrayRef> | ||
| where | ||
| Self: Sized, |
There was a problem hiding this comment.
Why does this need Self: Sized but into_canonical doesn't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.