Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BitPackedArray ptype changed by compute funcs #1724

Merged
merged 8 commits into from
Dec 19, 2024
+93 −21
Merged

fix: BitPackedArray ptype changed by compute funcs #1724

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65925dd
fix: BitPackedArray ptype changed by compute funcs
a10y Dec 19, 2024
11761b5
print query when panicking
a10y Dec 19, 2024
34be58d
turn it up to 11
a10y Dec 19, 2024
3da5540
fix TakeFn
a10y Dec 19, 2024
d6edda8
use as_nonnullable for comparing patches and array dtypes
a10y Dec 19, 2024
05e8461
try harder
a10y Dec 19, 2024
92d9baa
lol
a10y Dec 19, 2024
2dda7b9
eq_ignore_nullability
a10y Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion encodings/fastlanes/src/bitpacking/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ impl BitPackedArray {

if let Some(ref patches) = patches {
// Ensure that array and patches have same PType
if patches.dtype() != &DType::from(ptype) {
if patches.dtype().as_nonnullable() != DType::from(ptype).as_nonnullable() {
a10y marked this conversation as resolved.
Show resolved Hide resolved
vortex_bail!(
"Patches DType {} does not match BitPackedArray dtype {}",
patches.dtype().as_nonnullable(),
Expand Down