Skip FoR decompression if min and scalar are 0 #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwwmanning
reviewed
Dec 9, 2024
| validity, | ||
| ) | ||
| if min == 0 && shift == 0 { | ||
| encoded |
There was a problem hiding this comment.
do we need to cast? (real question)
There was a problem hiding this comment.
In this context we know that min is T so I think compiler will cast 0 to T implicitly
There was a problem hiding this comment.
oh no, I mean cast encoded... is it the right dtype/ptype? since FoR converts to unsigned
There was a problem hiding this comment.
The cast happens above when we extract the encoded array
lwwmanning
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.