chore: add an unsafe take_unchecked to TakeFn for bounds check ellision #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Random Access
| Benchmark suite | Current: e36a51a | Previous: 130c08d | Ratio |
|---|---|---|---|
random-access/vortex-tokio-local-disk |
3897329.911538461 ns (24353.08370192279) |
3858251.619999999 ns (28873.964230769547) |
1.01 |
random-access/vortex-local-fs |
4066693.0384615366 ns (26567.138788461685) |
3996156.2153846156 ns (28616.208346154308) |
1.02 |
random-access/parquet-tokio-local-disk |
222645037.7 ns (2949222.4433333427) |
221103606.7666667 ns (2323244.150000006) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
DataFusion
| Benchmark suite | Current: e36a51a | Previous: 130c08d | Ratio |
|---|---|---|---|
arrow/planning |
805284.4370219578 ns (1769.4012375573511) |
811105.0833481516 ns (2132.746192966879) |
0.99 |
arrow/exec |
1762518.7253831145 ns (6868.240758457105) |
1759350.0488630899 ns (5901.056102917995) |
1.00 |
vortex-pushdown-compressed/planning |
506966.9772897119 ns (1211.540145975916) |
505721.4699823582 ns (1453.6451635199483) |
1.00 |
vortex-pushdown-compressed/exec |
2691917.944736841 ns (6613.939723683754) |
2673188.271052631 ns (9313.746723683551) |
1.01 |
vortex-pushdown-uncompressed/planning |
500964.56648714625 ns (998.8708786102652) |
501643.0767110315 ns (2210.397715811734) |
1.00 |
vortex-pushdown-uncompressed/exec |
1496168.0496497941 ns (4026.3196468651295) |
1495061.5646274583 ns (4875.1233805362135) |
1.00 |
vortex-nopushdown-compressed/planning |
838309.0805647465 ns (1783.2057474181056) |
843315.588731761 ns (1851.3062223231536) |
0.99 |
vortex-nopushdown-compressed/exec |
3032353.084444444 ns (9020.43885416654) |
2948911.8064705883 ns (13796.120360293193) |
1.03 |
vortex-nopushdown-uncompressed/planning |
823547.0508466109 ns (1411.4965454428457) |
823778.8997028836 ns (1499.31155929924) |
1.00 |
vortex-nopushdown-uncompressed/exec |
4913552.978181818 ns (12217.048749999609) |
4905632.3881818205 ns (17196.13409090927) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
TPC-H
| Benchmark suite | Current: e36a51a | Previous: 130c08d | Ratio |
|---|---|---|---|
tpch_q01/arrow |
544055579 ns |
553974343 ns |
0.98 |
tpch_q01/vortex-file-compressed |
475437666 ns |
477660899 ns |
1.00 |
tpch_q02/arrow |
133527864 ns |
145055672 ns |
0.92 |
tpch_q02/vortex-file-compressed |
139916538 ns |
155983959 ns |
0.90 |
tpch_q03/arrow |
155584848 ns |
179696661 ns |
0.87 |
tpch_q03/vortex-file-compressed |
214307806 ns |
239974127 ns |
0.89 |
tpch_q04/arrow |
171602125 ns |
184837950 ns |
0.93 |
tpch_q04/vortex-file-compressed |
153518018 ns |
166208872 ns |
0.92 |
tpch_q05/arrow |
303272208 ns |
339829480 ns |
0.89 |
tpch_q05/vortex-file-compressed |
337661431 ns |
368955587 ns |
0.92 |
tpch_q06/arrow |
26289382 ns |
26849098 ns |
0.98 |
tpch_q06/vortex-file-compressed |
76369080 ns |
74014462 ns |
1.03 |
tpch_q07/arrow |
590019639 ns |
642240717 ns |
0.92 |
tpch_q07/vortex-file-compressed |
641511714 ns |
689847760 ns |
0.93 |
tpch_q08/arrow |
247921413 ns |
266191373 ns |
0.93 |
tpch_q08/vortex-file-compressed |
321238965 ns |
353012379 ns |
0.91 |
tpch_q09/arrow |
454356516 ns |
507057979 ns |
0.90 |
tpch_q09/vortex-file-compressed |
545695408 ns |
572083628 ns |
0.95 |
tpch_q10/arrow |
255132410 ns |
278914690 ns |
0.91 |
tpch_q10/vortex-file-compressed |
272383398 ns |
294804119 ns |
0.92 |
tpch_q11/arrow |
131393707 ns |
143124771 ns |
0.92 |
tpch_q11/vortex-file-compressed |
120970204 ns |
136943396 ns |
0.88 |
tpch_q12/arrow |
174734658 ns |
181514540 ns |
0.96 |
tpch_q12/vortex-file-compressed |
228580825 ns |
248152473 ns |
0.92 |
tpch_q13/arrow |
166297773 ns |
180287992 ns |
0.92 |
tpch_q13/vortex-file-compressed |
175881064 ns |
185794622 ns |
0.95 |
tpch_q14/arrow |
34687841 ns |
38718681 ns |
0.90 |
tpch_q14/vortex-file-compressed |
79332302 ns |
82842049 ns |
0.96 |
tpch_q15/arrow |
66922276 ns |
71754163 ns |
0.93 |
tpch_q15/vortex-file-compressed |
128527474 ns |
134620961 ns |
0.95 |
tpch_q16/arrow |
98446689 ns |
107078300 ns |
0.92 |
tpch_q16/vortex-file-compressed |
100042482 ns |
114678619 ns |
0.87 |
tpch_q17/arrow |
609459959 ns |
629484011 ns |
0.97 |
tpch_q17/vortex-file-compressed |
558037443 ns |
588134776 ns |
0.95 |
tpch_q18/arrow |
1127547019 ns |
1180501697 ns |
0.96 |
tpch_q18/vortex-file-compressed |
1154481468 ns |
1201977020 ns |
0.96 |
tpch_q19/arrow |
149569235 ns |
153392397 ns |
0.98 |
tpch_q19/vortex-file-compressed |
121500524 ns |
130614399 ns |
0.93 |
tpch_q20/arrow |
207774183 ns |
228229076 ns |
0.91 |
tpch_q20/vortex-file-compressed |
250806932 ns |
265990497 ns |
0.94 |
tpch_q21/arrow |
967853136 ns |
1009234190 ns |
0.96 |
tpch_q21/vortex-file-compressed |
899607765 ns |
976214704 ns |
0.92 |
tpch_q22/arrow |
75237141 ns |
80596757 ns |
0.93 |
tpch_q22/vortex-file-compressed |
84259893 ns |
88956829 ns |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Clickbench
| Benchmark suite | Current: e36a51a | Previous: 130c08d | Ratio |
|---|---|---|---|
clickbench_q00/vortex-file-compressed |
2101795 ns |
2081427 ns |
1.01 |
clickbench_q01/vortex-file-compressed |
38081317 ns |
36488917 ns |
1.04 |
clickbench_q02/vortex-file-compressed |
75449450 ns |
76376289 ns |
0.99 |
clickbench_q03/vortex-file-compressed |
78212697 ns |
80044003 ns |
0.98 |
clickbench_q04/vortex-file-compressed |
619534194 ns |
602476750 ns |
1.03 |
clickbench_q05/vortex-file-compressed |
612556767 ns |
606724644 ns |
1.01 |
clickbench_q06/vortex-file-compressed |
2295499 ns |
2249700 ns |
1.02 |
clickbench_q07/vortex-file-compressed |
51680747 ns |
50849623 ns |
1.02 |
clickbench_q08/vortex-file-compressed |
1032600428 ns |
1006174775 ns |
1.03 |
clickbench_q09/vortex-file-compressed |
884762036 ns |
866341028 ns |
1.02 |
clickbench_q10/vortex-file-compressed |
209371386 ns |
203045816 ns |
1.03 |
clickbench_q11/vortex-file-compressed |
255335652 ns |
247008852 ns |
1.03 |
clickbench_q12/vortex-file-compressed |
614995532 ns |
618212949 ns |
0.99 |
clickbench_q13/vortex-file-compressed |
964906228 ns |
937111680 ns |
1.03 |
clickbench_q14/vortex-file-compressed |
751471111 ns |
727623993 ns |
1.03 |
clickbench_q15/vortex-file-compressed |
751146549 ns |
694247153 ns |
1.08 |
clickbench_q16/vortex-file-compressed |
1771942127 ns |
1766664009 ns |
1.00 |
clickbench_q17/vortex-file-compressed |
1652092251 ns |
1606765496 ns |
1.03 |
clickbench_q18/vortex-file-compressed |
3708753908 ns |
3712659426 ns |
1.00 |
clickbench_q19/vortex-file-compressed |
66627044 ns |
64426441 ns |
1.03 |
clickbench_q20/vortex-file-compressed |
711097032 ns |
718013204 ns |
0.99 |
clickbench_q21/vortex-file-compressed |
943994539 ns |
917254664 ns |
1.03 |
clickbench_q22/vortex-file-compressed |
2099993672 ns |
2105008510 ns |
1.00 |
clickbench_q23/vortex-file-compressed |
5693672557 ns |
5678684165 ns |
1.00 |
clickbench_q24/vortex-file-compressed |
396847216 ns |
421069379 ns |
0.94 |
clickbench_q25/vortex-file-compressed |
356563350 ns |
379593790 ns |
0.94 |
clickbench_q26/vortex-file-compressed |
444076604 ns |
465347240 ns |
0.95 |
clickbench_q27/vortex-file-compressed |
1380442720 ns |
1383496731 ns |
1.00 |
clickbench_q28/vortex-file-compressed |
10649020315 ns |
10597664079 ns |
1.00 |
clickbench_q29/vortex-file-compressed |
703241423 ns |
688859759 ns |
1.02 |
clickbench_q30/vortex-file-compressed |
646217833 ns |
657502291 ns |
0.98 |
clickbench_q31/vortex-file-compressed |
624839713 ns |
630488937 ns |
0.99 |
clickbench_q32/vortex-file-compressed |
3024171477 ns |
2960429971 ns |
1.02 |
clickbench_q33/vortex-file-compressed |
2616029568 ns |
2614535934 ns |
1.00 |
clickbench_q34/vortex-file-compressed |
2530954264 ns |
2632584533 ns |
0.96 |
clickbench_q35/vortex-file-compressed |
1393460389 ns |
1390918970 ns |
1.00 |
clickbench_q36/vortex-file-compressed |
163823423 ns |
135190626 ns |
1.21 |
clickbench_q37/vortex-file-compressed |
112574738 ns |
91630455 ns |
1.23 |
clickbench_q38/vortex-file-compressed |
90819503 ns |
84098660 ns |
1.08 |
clickbench_q39/vortex-file-compressed |
297631424 ns |
218861666 ns |
1.36 |
clickbench_q40/vortex-file-compressed |
54741112 ns |
52523166 ns |
1.04 |
clickbench_q41/vortex-file-compressed |
56874896 ns |
55030130 ns |
1.03 |
clickbench_q42/vortex-file-compressed |
68181979 ns |
60925639 ns |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Vortex Compression
| Benchmark suite | Current: e36a51a | Previous: 130c08d | Ratio |
|---|---|---|---|
compress time/taxi |
1308678936.5 ns (3472284.6687500477) |
1306608663.2 ns (1426113.0499999523) |
1.00 |
compress time/taxi throughput |
470810830 bytes |
470810830 bytes |
1 |
parquet_rs-zstd compress time/taxi |
1686736816.8 ns (7097148.524999976) |
1675381704.5 ns (4898481.451249957) |
1.01 |
parquet_rs-zstd compress time/taxi throughput |
470810830 bytes |
470810830 bytes |
1 |
decompress time/taxi |
313867673 ns (2048262.6987499893) |
300760606.65 ns (1391355.900000006) |
1.04 |
decompress time/taxi throughput |
470810830 bytes |
470810830 bytes |
1 |
parquet_rs-zstd decompress time/taxi |
307994863.3 ns (647392.367500037) |
309087767.7 ns (583618.599999994) |
1.00 |
parquet_rs-zstd decompress time/taxi throughput |
470810830 bytes |
470810830 bytes |
1 |
vortex:parquet-zstd size/taxi |
1.007782982412156 ratio |
1.007782982412156 ratio |
1 |
vortex:raw size/taxi |
0.11978558776993299 ratio |
0.11978558776993299 ratio |
1 |
vortex size/taxi |
56396352 bytes |
56396352 bytes |
1 |
compress time/AirlineSentiment |
690984.0607888408 ns (1627.382913885871) |
701237.9942329059 ns (1446.8456302884151) |
0.99 |
compress time/AirlineSentiment throughput |
2066 bytes |
2066 bytes |
1 |
parquet_rs-zstd compress time/AirlineSentiment |
55904.04739411503 ns (183.22614076200625) |
55783.52713857694 ns (345.5270479309911) |
1.00 |
parquet_rs-zstd compress time/AirlineSentiment throughput |
2066 bytes |
2066 bytes |
1 |
decompress time/AirlineSentiment |
108858.86176531715 ns (518.9247411693214) |
109067.08043535493 ns (538.3484620181334) |
1.00 |
decompress time/AirlineSentiment throughput |
2066 bytes |
2066 bytes |
1 |
parquet_rs-zstd decompress time/AirlineSentiment |
32827.83919023847 ns (46.21746426638492) |
31974.16034015403 ns (74.11170121585565) |
1.03 |
parquet_rs-zstd decompress time/AirlineSentiment throughput |
2066 bytes |
2066 bytes |
1 |
vortex:parquet-zstd size/AirlineSentiment |
9.311271975180972 ratio |
9.311271975180972 ratio |
1 |
vortex:raw size/AirlineSentiment |
4.358180058083253 ratio |
4.358180058083253 ratio |
1 |
vortex size/AirlineSentiment |
9004 bytes |
9004 bytes |
1 |
compress time/Arade |
2694141549.9 ns (5216943.912499905) |
2662886180.1 ns (3873212.3499999046) |
1.01 |
compress time/Arade throughput |
787035849 bytes |
787035849 bytes |
1 |
parquet_rs-zstd compress time/Arade |
2884024559.4 ns (4150453.68874979) |
2857940934.6 ns (10808068.043750048) |
1.01 |
parquet_rs-zstd compress time/Arade throughput |
787035849 bytes |
787035849 bytes |
1 |
decompress time/Arade |
531837300.9 ns (1910798.9637500048) |
501220181.5 ns (2632143.7287499905) |
1.06 |
decompress time/Arade throughput |
787035849 bytes |
787035849 bytes |
1 |
parquet_rs-zstd decompress time/Arade |
671680230 ns (1918551.050000012) |
674747257.2 ns (2620598.5499999523) |
1.00 |
parquet_rs-zstd decompress time/Arade throughput |
787035849 bytes |
787035849 bytes |
1 |
vortex:parquet-zstd size/Arade |
0.4768828177957864 ratio |
0.4768828177957864 ratio |
1 |
vortex:raw size/Arade |
0.1850446128788728 ratio |
0.1850446128788728 ratio |
1 |
vortex size/Arade |
145636744 bytes |
145636744 bytes |
1 |
compress time/Bimbo |
10550885372.4 ns (7536723.034999847) |
10722753530.9 ns (10385513.666249275) |
0.98 |
compress time/Bimbo throughput |
7121348333 bytes |
7121348333 bytes |
1 |
parquet_rs-zstd compress time/Bimbo |
19130452085.3 ns (45418521.43250084) |
19314286704.8 ns (48460965.52499962) |
0.99 |
parquet_rs-zstd compress time/Bimbo throughput |
7121348333 bytes |
7121348333 bytes |
1 |
decompress time/Bimbo |
3542702414.2 ns (5485699.146250248) |
3534059492.6 ns (8965918.108750105) |
1.00 |
decompress time/Bimbo throughput |
7121348333 bytes |
7121348333 bytes |
1 |
parquet_rs-zstd decompress time/Bimbo |
2662419735 ns (13020210.950000048) |
2704788703.4 ns (7285154.377499819) |
0.98 |
parquet_rs-zstd decompress time/Bimbo throughput |
7121348333 bytes |
7121348333 bytes |
1 |
vortex:parquet-zstd size/Bimbo |
1.4471599130616626 ratio |
1.4471587588715804 ratio |
1.00 |
vortex:raw size/Bimbo |
0.07887783292344112 ratio |
0.07887777001400614 ratio |
1.00 |
vortex size/Bimbo |
561716524 bytes |
561716076 bytes |
1.00 |
compress time/CMSprovider |
12789633072.1 ns (20721953.17124939) |
12930957005.1 ns (8546254.418748856) |
0.99 |
compress time/CMSprovider throughput |
5149200493 bytes |
5149200493 bytes |
1 |
parquet_rs-zstd compress time/CMSprovider |
18254718488.8 ns (28113907.550001144) |
18544850030.9 ns (41180060.01250076) |
0.98 |
parquet_rs-zstd compress time/CMSprovider throughput |
5149200493 bytes |
5149200493 bytes |
1 |
decompress time/CMSprovider |
2973382519.5 ns (395732363.20000005) |
2955977952.4 ns (364573463.10375) |
1.01 |
decompress time/CMSprovider throughput |
5149200493 bytes |
5149200493 bytes |
1 |
parquet_rs-zstd decompress time/CMSprovider |
5474194167.3 ns (9417854.303750038) |
5530326678.1 ns (13683416.32375002) |
0.99 |
parquet_rs-zstd decompress time/CMSprovider throughput |
5149200493 bytes |
5149200493 bytes |
1 |
vortex:parquet-zstd size/CMSprovider |
1.2625014843451499 ratio |
1.2625444828894967 ratio |
1.00 |
vortex:raw size/CMSprovider |
0.18868283985461043 ratio |
0.1886764761482361 ratio |
1.00 |
vortex size/CMSprovider |
971565772 bytes |
971533004 bytes |
1.00 |
compress time/Euro2016 |
2172952161.2 ns (3310848.5237500668) |
2158921743.5 ns (7131129.25) |
1.01 |
compress time/Euro2016 throughput |
393256178 bytes |
393256178 bytes |
1 |
parquet_rs-zstd compress time/Euro2016 |
1537208690.9 ns (3669142.1500000954) |
1532879404.2 ns (3173281.75) |
1.00 |
parquet_rs-zstd compress time/Euro2016 throughput |
393256178 bytes |
393256178 bytes |
1 |
decompress time/Euro2016 |
248637250.1 ns (832614.8650000095) |
245783440.6 ns (838506.7587500066) |
1.01 |
decompress time/Euro2016 throughput |
393256178 bytes |
393256178 bytes |
1 |
parquet_rs-zstd decompress time/Euro2016 |
493012972.1 ns (2068228.25) |
490420768.2 ns (1172202.25) |
1.01 |
parquet_rs-zstd decompress time/Euro2016 throughput |
393256178 bytes |
393256178 bytes |
1 |
vortex:parquet-zstd size/Euro2016 |
1.421055821615923 ratio |
1.421055821615923 ratio |
1 |
vortex:raw size/Euro2016 |
0.4296160758598432 ratio |
0.4296160758598432 ratio |
1 |
vortex size/Euro2016 |
168949176 bytes |
168949176 bytes |
1 |
compress time/Food |
987118197.2 ns (3960818.7012500167) |
975407220.7 ns (1340280.3325000405) |
1.01 |
compress time/Food throughput |
332721678 bytes |
332721678 bytes |
1 |
parquet_rs-zstd compress time/Food |
1034521415.6 ns (2641992.683749974) |
1025070835.2 ns (2342103.003750026) |
1.01 |
parquet_rs-zstd compress time/Food throughput |
332721678 bytes |
332721678 bytes |
1 |
decompress time/Food |
115791326.07115078 ns (252034.24164981395) |
114977301.3234127 ns (307496.99944443256) |
1.01 |
decompress time/Food throughput |
332721678 bytes |
332721678 bytes |
1 |
parquet_rs-zstd decompress time/Food |
221772762.55 ns (490051.003124997) |
223733939.75 ns (582118.2993749976) |
0.99 |
parquet_rs-zstd decompress time/Food throughput |
332721678 bytes |
332721678 bytes |
1 |
vortex:parquet-zstd size/Food |
1.2535018411392786 ratio |
1.2535018411392786 ratio |
1 |
vortex:raw size/Food |
0.13649362516138788 ratio |
0.13649362516138788 ratio |
1 |
vortex size/Food |
45414388 bytes |
45414388 bytes |
1 |
compress time/HashTags |
2650484489.8 ns (6190098.97874999) |
2626353712.1 ns (5876004.166249752) |
1.01 |
compress time/HashTags throughput |
804503131 bytes |
804503131 bytes |
1 |
parquet_rs-zstd compress time/HashTags |
2418359551.3 ns (2839705.75) |
2421884647.8 ns (4016454.5500001907) |
1.00 |
parquet_rs-zstd compress time/HashTags throughput |
804503131 bytes |
804503131 bytes |
1 |
decompress time/HashTags |
457988458.4 ns (884583.875) |
463341184.8 ns (1878902.9962500036) |
0.99 |
decompress time/HashTags throughput |
804503131 bytes |
804503131 bytes |
1 |
parquet_rs-zstd decompress time/HashTags |
780047507.1 ns (4828258.388750017) |
800334558.5 ns (1944948.5) |
0.97 |
parquet_rs-zstd decompress time/HashTags throughput |
804503131 bytes |
804503131 bytes |
1 |
vortex:parquet-zstd size/HashTags |
1.668376853270086 ratio |
1.668376853270086 ratio |
1 |
vortex:raw size/HashTags |
0.27781736004207047 ratio |
0.27781736004207047 ratio |
1 |
vortex size/HashTags |
223504936 bytes |
223504936 bytes |
1 |
compress time/TPC-H l_comment chunked without fsst |
3398866071.2 ns (11096255.450000048) |
3441878510.1 ns (18104243.421249866) |
0.99 |
compress time/TPC-H l_comment chunked without fsst throughput |
249225147 bytes |
249225147 bytes |
1 |
parquet_rs-zstd compress time/TPC-H l_comment chunked without fsst |
903242016.1 ns (1830986.75) |
911648945.4 ns (1409689.094999969) |
0.99 |
parquet_rs-zstd compress time/TPC-H l_comment chunked without fsst throughput |
249225147 bytes |
249225147 bytes |
1 |
decompress time/TPC-H l_comment chunked without fsst |
120352400.5 ns (661581.3900000006) |
75326549.8 ns (11095244.485) |
1.60 |
decompress time/TPC-H l_comment chunked without fsst throughput |
249225147 bytes |
249225147 bytes |
1 |
parquet_rs-zstd decompress time/TPC-H l_comment chunked without fsst |
248346792 ns (727943.9650000036) |
251535632.3 ns (628925.856250003) |
0.99 |
parquet_rs-zstd decompress time/TPC-H l_comment chunked without fsst throughput |
249225147 bytes |
249225147 bytes |
1 |
vortex:parquet-zstd size/TPC-H l_comment chunked without fsst |
4.608025786841012 ratio |
4.608179950286349 ratio |
1.00 |
vortex:raw size/TPC-H l_comment chunked without fsst |
1.052730525623885 ratio |
1.0527793168479904 ratio |
1.00 |
vortex size/TPC-H l_comment chunked without fsst |
262366920 bytes |
262379080 bytes |
1.00 |
compress time/TPC-H l_comment chunked |
997116837.1 ns (1679661.3500000238) |
993277541.2 ns (2377328.8412500024) |
1.00 |
compress time/TPC-H l_comment chunked throughput |
249225147 bytes |
249225147 bytes |
1 |
parquet_rs-zstd compress time/TPC-H l_comment chunked |
903302757.4 ns (2506424.399999976) |
913021459.1 ns (1616971.0162500143) |
0.99 |
parquet_rs-zstd compress time/TPC-H l_comment chunked throughput |
249225147 bytes |
249225147 bytes |
1 |
decompress time/TPC-H l_comment chunked |
92967437.26984127 ns (175305.7235456407) |
95294229.87857144 ns (152737.51071428508) |
0.98 |
decompress time/TPC-H l_comment chunked throughput |
249225147 bytes |
249225147 bytes |
1 |
parquet_rs-zstd decompress time/TPC-H l_comment chunked |
248426658.35 ns (835654.2287499905) |
252467220.85 ns (1052273.450000003) |
0.98 |
parquet_rs-zstd decompress time/TPC-H l_comment chunked throughput |
249225147 bytes |
249225147 bytes |
1 |
vortex:parquet-zstd size/TPC-H l_comment chunked |
1.1622480566090065 ratio |
1.1622229574119818 ratio |
1.00 |
vortex:raw size/TPC-H l_comment chunked |
0.2655223872733838 ratio |
0.26552007611013667 ratio |
1.00 |
vortex size/TPC-H l_comment chunked |
66174856 bytes |
66174280 bytes |
1.00 |
compress time/TPC-H l_comment canonical |
1002895998.1 ns (1929340.5868749619) |
992120150.25 ns (1309033.0781250596) |
1.01 |
compress time/TPC-H l_comment canonical throughput |
249224435 bytes |
249224435 bytes |
1 |
parquet_rs-zstd compress time/TPC-H l_comment canonical |
914820692.45 ns (2597531.2193749547) |
913911673.15 ns (1844825.5618749857) |
1.00 |
parquet_rs-zstd compress time/TPC-H l_comment canonical throughput |
249224435 bytes |
249224435 bytes |
1 |
decompress time/TPC-H l_comment canonical |
93891100.5287566 ns (311324.2838975042) |
96342648.40313491 ns (589729.1325362027) |
0.97 |
decompress time/TPC-H l_comment canonical throughput |
249224435 bytes |
249224435 bytes |
1 |
parquet_rs-zstd decompress time/TPC-H l_comment canonical |
248271813.81785712 ns (582528.883973226) |
251102684.64115077 ns (659778.5637500137) |
0.99 |
parquet_rs-zstd decompress time/TPC-H l_comment canonical throughput |
249224435 bytes |
249224435 bytes |
1 |
vortex:parquet-zstd size/TPC-H l_comment canonical |
1.1623125445297966 ratio |
1.1623004268494865 ratio |
1.00 |
vortex:raw size/TPC-H l_comment canonical |
0.26552314583439623 ratio |
0.26552083466454646 ratio |
1.00 |
vortex size/TPC-H l_comment canonical |
66174856 bytes |
66174280 bytes |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
gatesn
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation makes it possible to trigger UB solely from calling the safe public API for
take().This PR moves the unsafe variants of Take that assume bounds checking has been done into a separate
unsafe fn take_unchecked. This creates a clean separation between safe and unsafe (possible UB) codepaths.