Reuse the IoDispatcher across DataFusion instances #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
commented
Nov 14, 2024
| let rx: flume::Receiver<Box<dyn TokioSpawn + Send>> = rx.clone(); | ||
|
|
||
| worker_thread | ||
| .spawn(move || { | ||
| // Create a runtime-per-thread | ||
| let rt = tokio::runtime::Builder::new_current_thread() | ||
| .thread_name(format!("tokio-dispatch-{tid}")) |
There was a problem hiding this comment.
Tokio overrides the thread name, so have to set it here not above
lwwmanning
approved these changes
Nov 14, 2024
a10y
previously requested changes
Nov 14, 2024
gatesn
force-pushed
the
ngates/reuse-dispatcher-datafusion
branch
from
bc13d66 to
f5994c1
Compare
a10y
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.