Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve docs & unit test coverage for vortex-dtype #1182

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

lwwmanning
Copy link
Member

@lwwmanning lwwmanning commented Nov 1, 2024

also improve test coverage of vortex-dtype crate

@lwwmanning lwwmanning enabled auto-merge (squash) November 1, 2024 18:38
@lwwmanning lwwmanning changed the title deny missing_docs on vortex-dtype feat: improve docs & unit test coverage for vortex-dtype Nov 1, 2024
pub fn field_info(&self, field: &Field) -> VortexResult<FieldInfo> {
let index = match field {
Field::Name(name) => self
.find_name(name)
.ok_or_else(|| vortex_err!("Unknown field: {}", name))?,
Field::Index(index) => *index,
};
if index > self.names.len() {
if index >= self.names.len() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests actually found a latent bug

vortex-dtype/src/serde/mod.rs Outdated Show resolved Hide resolved
@lwwmanning lwwmanning merged commit 45f69cb into develop Nov 1, 2024
5 checks passed
@lwwmanning lwwmanning deleted the wm/dtype-docs branch November 1, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants