Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support null constant arrays in into canonical #1171

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat: support null constant arrays in into canonical #1171

merged 1 commit into from
Nov 1, 2024

Conversation

danking
Copy link
Member

@danking danking commented Oct 31, 2024

No description provided.

@danking danking requested a review from lwwmanning October 31, 2024 19:42
@danking danking marked this pull request as ready for review October 31, 2024 19:42
robert3005
robert3005 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m curious how this happens given we don’t really use null dtype

@danking
Copy link
Member Author

danking commented Nov 1, 2024

I think it was Arade. Must have an all null column in the first file.

@danking danking merged commit f7a4d61 into develop Nov 1, 2024
4 checks passed
@danking danking deleted the dk/null-constant-is-canonical branch November 1, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwwmanning lwwmanning lwwmanning approved these changes

@robert3005 robert3005 robert3005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danking @robert3005 @lwwmanning