add fuzzer, fix bug #7
Merged
+203
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Aug 15, 2024
| use libfuzzer_sys::fuzz_target; | ||
|
|
||
| fuzz_target!(|data: &[u8]| { | ||
| let _ = fsst_rs::train(data); |
There was a problem hiding this comment.
this one is slow b/c the train function is still relatively slow, so I don't run this target in CI. once we improve performance to match compress we can turn this back on
Merged
a10y
pushed a commit
that referenced
this pull request
Aug 15, 2024
## 🤖 New release * `fsst-rs`: 0.0.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.0.1](https://github.com/spiraldb/fsst/releases/tag/v0.0.1) - 2024-08-15 ### Fixed - fix doc link ### Other - turn on release-plz - add fuzzer, fix bug ([#7](#7)) - logo ([#6](#6)) - bugfix, comment fix, force compile fails for big-endian ([#5](#5)) - Configure Renovate ([#1](#1)) - Get compress performance to match paper algorithm 4 ([#3](#3)) - docs - cleanup - words - README - disable release action for now - deny(missing_docs), 512 -> 511 - add toolchain - add actions files - implementation v0 - initial impl - Initial commit </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial fuzzer setup, runs
cargo fuzzon a schedule like Vortex repo.There was an out-of-bound access in the
compressfunction when loading the last 8 byte word. I replaced it with a copy that is safer while also preserving our existing performance.