generated from spiral-packages/package-skeleton
-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Temporal Connection Configuration with SSL Support and Flexibility #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport This commit significantly overhauls the Temporal connection configuration system. The previous configuration was limited to specifying a single Temporal address with no support for SSL connections. With the new setup, developers can now define multiple connection options, including SSL-enabled connections. Changes include: - Introduction of a 'connections' array to specify multiple connection types (e.g., `default`, `SSL`). - Addition of the `SslConnection` class to handle SSL connection parameters such as certificates and keys. - Preservation of backward compatibility by supporting the previous `address` configuration under the `default` connection type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #83 +/- ##
============================================
- Coverage 99.14% 95.82% -3.33%
- Complexity 103 121 +18
============================================
Files 15 18 +3
Lines 352 431 +79
============================================
+ Hits 349 413 +64
- Misses 3 18 +15 ☔ View full report in Codecov by Sentry. |
roxblnfk
reviewed
Mar 22, 2024
Co-authored-by: Aleksei Gagarin <[email protected]>
Co-authored-by: Aleksei Gagarin <[email protected]>
Co-authored-by: Aleksei Gagarin <[email protected]>
roxblnfk
reviewed
Mar 26, 2024
See temporalio/sdk-php#410 |
Co-authored-by: Aleksei Gagarin <[email protected]>
# Conflicts: # composer.json # src/Bootloader/TemporalBridgeBootloader.php
roxblnfk
force-pushed
the
feature/ssl-conection-support
branch
from
August 28, 2024 11:46
c97bbc3
to
a00adcf
Compare
roxblnfk
force-pushed
the
feature/ssl-conection-support
branch
from
August 29, 2024 08:05
acd773d
to
d94eb74
Compare
roxblnfk
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to configure multiple connections to Temporal servers, including SSL-enabled connections. It aims to provide greater flexibility and security in connection setup, improving upon the previous single-address configuration approach.
What was changed
address
,clientOptions
,temporalNamespace
still work, but a deprecation warning will be issued.Previous Configuration:
**New Configuration: