-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transferred/received amounts in statistics page #1300
base: main
Are you sure you want to change the base?
Conversation
zorun
commented
Mar 29, 2024
Names are temporary, see discussion in #1299 I have tried several orders for the column, this one seems clearer to me, but I'm intestered in feedback. The negative signs are intended to show that all columns should sum to the balance. |
Some ideas for improving the rendering after showing this to somebody:
|
Hi, thanks for the proposed changes. I'm not sure you need a review, or do you want to keep on adding things? 🤔 It could be improved, but at the same time it feels like it could just already add some values to the stats page. |
f62ca85
to
5bb311e
Compare
The rationale for this naming choice has been discussed in issue spiral-project#1299
I've just rebased this on top of the latest |
(I plan to merge if/when tests are green) |
d29236e
to
0a50941
Compare
The tests should be passing now, but it seems that they change the way the balance is working. Before these changes, a reimbursement to somebody would remove the amount from how much somebody has paid, and now it's not the case anymore. I'm for merging this, as it seems to be the "good" behavior, but that might be a surprise for some clients. Because it's changing the API we're exposing, we probably should issue a major release with the next release. As this is changing some code you did @zorun, it would be great if you can review the changes I did. |