Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding issues cause deactivated users to reappear indefinitely #1336

Open
pH142857 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #1363
Open

Rounding issues cause deactivated users to reappear indefinitely #1336

pH142857 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #1363

Comments

@pH142857
Copy link

pH142857 commented Dec 19, 2024

Users who have been set to a balance of zero and deactivated keep reappearing with a balance of ±0,01. I thought I could get rid of the problem by make up for it with a fake transaction, but I can't: bad rounding causes a specific user to have either +0,01 or -0,01. What's more, to create a fake transaction I have to reactivate the user, and this alone is a problem because of possible side effects.

It is hard to replicate but if you have access to serverside data I can tell you which project have this issue on the hosted service.

By the way, is this project maintained? It doesn't seem very active.

@almet
Copy link
Member

almet commented Dec 19, 2024

It is hard to replicate but if you have access to serverside data I can tell you which project have this issue on the hosted service.

Yep, that would be welcome, so we can have a look, thanks for opening an issue :-)

By the way, is this project maintained? It doesn't seem very active.

You're right, we're doing the minimum service right now, and are in maintainance mode, see https://github.com/spiral-project/ihatemoney?tab=readme-ov-file#current-direction-as-of-2024 for more info.

@pH142857
Copy link
Author

Great, I'm all for stability and simplicity!
Concern project is coloc-du-77. Concerned username is Natan.

almet added a commit that referenced this issue Dec 27, 2024
Cases has been reported of rounding issues making deactivated users
reapparing. This is due to the fact we're using floats (see #528 for
details)

Fixes #1336
almet added a commit that referenced this issue Dec 28, 2024
Cases has been reported of rounding issues making deactivated users
reapparing. This is due to the fact we're using floats (see #528 for
details)

Fixes #1336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants