Bill Type: Invalid Choice: could not coerce.

[rriski]

After #1290 I receive "Bill Type: Invalid Choice: could not coerce" when attempting to add new bills. Changing the bill type doesn't help.

The request that is going out to POST /<project>/add:

csrf_token=...
date=2024-03-22
bill_type=BillType.EXPENSE
what=test
payer=10
amount=1
payed_for=1
payed_for=2
submit=Submit

I believe the issue could be in how the BillType enum is coerced by WTForms, see https://stackoverflow.com/a/49376245. BillType doesn't have a coerce classmethod:

ihatemoney/ihatemoney/models.py

Lines 54 to 60 in 4af4c10

	class BillType(Enum):
	EXPENSE = "Expense"
	REIMBURSEMENT = "Reimbursement"
	@classmethod
	def choices(cls):
	return [(choice, choice.value) for choice in cls]

.

I'm running the ihatemoney/ihatemoney:master docker image. Here are my pip dependencies:

/ # pip3 list
Package              Version      Editable project location
-------------------- ------------ -------------------------
alembic              1.13.1
aniso8601            9.0.1
Babel                2.14.0
blinker              1.7.0
cachetools           4.2.4
certifi              2024.2.2
charset-normalizer   3.3.2
click                8.1.7
commonmark           0.9.1
debts                0.5
Deprecated           1.2.14
dnspython            2.6.1
email_validator      2.1.1
Flask                2.3.3
flask-babel          3.1.0
Flask-Cors           3.0.10
Flask-Limiter        2.9.2
Flask-Mail           0.9.1
Flask-Migrate        4.0.7
Flask-RESTful        0.3.10
Flask-SQLAlchemy     2.5.1
flask-talisman       1.1.0
Flask-WTF            1.2.1
greenlet             3.0.3
gunicorn             21.2.0
idna                 3.6
ihatemoney           6.2.0.dev0   /src
importlib_resources  6.3.2
itsdangerous         2.1.2
Jinja2               3.1.3
limits               3.10.1
Mako                 1.3.2
MarkupSafe           2.1.5
ordered-set          4.1.0
packaging            24.0
pip                  23.0.1
psycopg2-binary      2.9.9
Pygments             2.17.2
PyMySQL              1.0.3
pypng                0.20220715.0
python-dateutil      2.9.0.post0
pytz                 2024.1
qrcode               7.4.2
requests             2.31.0
rich                 12.6.0
setuptools           65.5.1
six                  1.16.0
SQLAlchemy           1.4.52
SQLAlchemy-Continuum 1.4.1
SQLAlchemy-Utils     0.41.1
typing_extensions    4.10.0
urllib3              2.2.1
Werkzeug             2.3.8
wheel                0.43.0
wrapt                1.16.0
WTForms              3.1.2

[zorun]

Ping @TomRoussel

[rriski]

Opened a PR with a fix #1294

[TomRoussel]

Hmm, I did manually test the form at one point. But I think I changed the way the frontend showed the bill type choices since then, sorry! I'll also have a look at the PR :)