Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

bug(http): random NPE on RR start #141

Merged
merged 4 commits into from
Dec 2, 2021
Merged

bug(http): random NPE on RR start #141

merged 4 commits into from
Dec 2, 2021

Conversation

rustatian
Copy link
Contributor

Reason for This PR

ref: roadrunner-server/roadrunner-plugins#143

Description of Changes

  • Fix bug in the RR-plugins.
  • Update dependencies.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

update deps

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added B-bug Bug: bug, exception stable-nominated Nominated for backporting to the RR-Binary in the beta channel. labels Dec 2, 2021
@rustatian rustatian requested a review from wolfy-j December 2, 2021 23:23
@rustatian rustatian self-assigned this Dec 2, 2021
@rustatian rustatian added this to the v2.6.2 milestone Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #141 (6610975) into master (3b4b35e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   43.73%   43.73%           
=======================================
  Files          12       12           
  Lines         567      567           
=======================================
  Hits          248      248           
  Misses        308      308           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4b35e...6610975. Read the comment docs.

Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit c33cbd8 into master Dec 2, 2021
@rustatian rustatian deleted the bug/npe-http-pool branch December 2, 2021 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B-bug Bug: bug, exception stable-nominated Nominated for backporting to the RR-Binary in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant