Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-45: Initial commit for automatic releases #51

Merged
merged 1 commit into from
Sep 14, 2021
Merged

gh-45: Initial commit for automatic releases #51

merged 1 commit into from
Sep 14, 2021

Conversation

viggy28
Copy link
Contributor

@viggy28 viggy28 commented Sep 12, 2021

No description provided.

@viggy28 viggy28 force-pushed the vicky/gh-45 branch 16 times, most recently from 0b30a57 to 8fe0d34 Compare September 12, 2021 20:59
@viggy28 viggy28 requested a review from idoqo September 12, 2021 21:08
@viggy28
Copy link
Contributor Author

viggy28 commented Sep 12, 2021

Good for review @idoqo

@viggy28 viggy28 force-pushed the vicky/gh-45 branch 4 times, most recently from 9f2fb17 to dbae487 Compare September 12, 2021 23:17
on:
push:
branches:
- "*"
Copy link
Collaborator

@idoqo idoqo Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the details of GitHub actions limits for teams, but running this for all branches won't give us issues, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally shoudln't, but you're right it may be an overkill to run for every commit in all branches. Restricting to run only on "main" branch.

@viggy28 viggy28 merged commit b004531 into main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants