Experiments with adding support for a variety of different handler types #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @spinscale,
I hope I'm not inundating you with too many pull requests!
I figured I'd try and learn some crystal and experiment with ways to make the handlers more generic and maintain a nice rubyish feel.
There is a lot of hacking here so I hope it isn't too distracting.
What I'm trying to accomplish is to allow for handlers that provide some convience and safety at the same time for different aws lambda use cases.
Some different scenarios I've come up with in this pull request:
This is accomplished by adding these additional register_handler definitions to the Runtime:
As well as additional logic to handle the specific types:
I'm still rather new to crystal so doing a bunch of fighting with the type system still. If you have any better ideas/approaches please let me know.
If you think this is a decent approach I'll clean it up, get tests in and add the additional lambda events supported by aws.