fix(qos): Use PolledMeter to prevent metric deletion by Garbage Collector #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor Depending on the load and configuration, the metric may be updated infrequently, and therefore the real value is deleted. As a result, instead of the value you see N/A. Replaced with PolledMeter to hold a strong reference
richard-timpson
approved these changes
Dec 10, 2024
christosarvanitis
approved these changes
Dec 11, 2024
dbyron-sf
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the load and configuration, the metric may be updated infrequently, and therefore the real value is deleted. As a result, instead of the value you see N/A. Replaced with PolledMeter to hold a strong reference