feat(SpEL): implement to configure the limit of characters for SpEL expressions #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jun 26, 2024
.../echo/pipelinetriggers/postprocessors/ExpectedArtifactExpressionEvaluationPostProcessor.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jun 26, 2024
| private final ParserContext parserContext = new TemplateParserContext("${", "}"); | ||
|
|
||
| public ExpectedArtifactExpressionEvaluationPostProcessor(ObjectMapper mapper) { | ||
| public ExpectedArtifactExpressionEvaluationPostProcessor( | ||
| ObjectMapper mapper, @Autowired ExpressionProperties expressionProperties) { |
There was a problem hiding this comment.
Is @Autowired required here. Doesn't everything get autowired via @Component?
There was a problem hiding this comment.
Yes, it is required as we are using it in constructor of a component and concluding its use inside the constructor.
There was a problem hiding this comment.
But...we don't have it for ObjectMapper. Why is ExpressionProperties different?
There was a problem hiding this comment.
I verified without using @Autowired, build and tests are passing. So, updating code as suggested.
j-sandy
force-pushed
the
spel-expr-len
branch
4 times, most recently
from
61e42b3 to
c39989a
Compare
…xpressions Spring Expression Lanuage (SpEL) has a default limit of 10,000 characters. Springframework provides the feature to configure the limit. This feature allows to configure the limit of characters for SpEL expressions. Approach: In order to use an expression with characters more than the given default limit, require to follow either of the below approaches: 1. For Springframework >=5.3.28 and <6.1.3, by setting `maximumExpressionLength` field while instantiating the custom `SpelParserConfiguration` class. spring-projects/spring-framework#30380 spring-projects/spring-framework#30446 2. For Springframework >=6.1.3, by setting a JVM system property or Spring property named `spring.context.expression.maxLength` to the maximum expression length needed by your application. spring-projects/spring-framework#31952 spring-projects/spring-framework@7855986 Spinnaker supports spring boot 2.7.18, that brings springframework 5.3.31 [https://docs.spring.io/spring-boot/docs/2.7.18/reference/html/dependency-versions.html#appendix.dependency-versions.propertie9]. So first approach need to be implemented along with spinnaker enhancement to expose the `maximumExpressionLength` field.
|
@Mergifyio update |
✅ Branch has been successfully updated |
dbyron-sf
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Expression Lanuage (SpEL) has a default limit of 10,000 characters. Springframework provides the feature to configure the limit. This feature allows to configure the limit of characters for SpEL expressions.
Approach:
In order to use an expression with characters more than the given default limit, require to follow either of the below approaches:
For Springframework >=5.3.28 and <6.1.3, by setting
maximumExpressionLengthfield while instantiating the customSpelParserConfigurationclass.Make maximum SpEL expression length configurable spring-projects/spring-framework#30380
Make maximum SpEL expression length configurable spring-projects/spring-framework#30446
For Springframework >=6.1.3, by setting a JVM system property or Spring property named
spring.context.expression.maxLengthto the maximum expression length needed by your application.Make maximum length of SpEL expressions in an
ApplicationContextconfigurable spring-projects/spring-framework#31952spring-projects/spring-framework@7855986
Spinnaker supports spring boot 2.7.18, that brings springframework 5.3.31 [https://docs.spring.io/spring-boot/docs/2.7.18/reference/html/dependency-versions.html#appendix.dependency-versions.propertie9]. So first approach need to be implemented along with spinnaker enhancement to expose the
maximumExpressionLengthfield.