Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helptext for checkPrecondition expression #1783

Closed

Conversation

riltsken
Copy link
Contributor

@riltsken riltsken commented Dec 7, 2015

Added helptext which points to Spring Expression Language so that users understand they can make complex evaluations here.

@riltsken riltsken force-pushed the add-helptext-for-expressions branch from 8e1bbd6 to a79c14e Compare December 7, 2015 23:29
@riltsken
Copy link
Contributor Author

riltsken commented Dec 7, 2015

By the way I wanted to add a link to the popover, but the popovers currently disappear when losing focus on the popover trigger element and the fix is some non-trivial event handling which could have an undesired effect. When angular-ui 1.0.0 rolls out it might be nice to take advantage of this fix angular-ui/bootstrap#4419

@anotherchrisberry
Copy link
Contributor

LGTM - can you rebase against master?

We will keep an eye on ui-bootstrap and upgrade to 1.0 when it is released.

@riltsken riltsken force-pushed the add-helptext-for-expressions branch from a79c14e to 61ba264 Compare December 8, 2015 16:02
@riltsken
Copy link
Contributor Author

riltsken commented Dec 8, 2015

Sorry, messed up this branch. #1784

@riltsken riltsken closed this Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants